[GitHub] [superset] rusackas commented on a diff in pull request #19485: fix: Set fixed maxWidth of the cron schedule modal

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19485:
URL: https://github.com/apache/superset/pull/19485#discussion_r856572701


##########
superset-frontend/src/components/ReportModal/styles.tsx:
##########
@@ -71,6 +71,7 @@ export const StyledScheduleTitle = styled.div`
 
 export const StyledCronPicker = styled(CronPicker)`
   margin-bottom: ${({ theme }) => theme.gridUnit * 3}px;
+  width: 450px;

Review Comment:
   ```suggestion
     width: ${({ theme }) => theme.gridUnit * 120}px;
   ```
   Is 480px too much? This seems like a nice round-ish number of gridUnits (divisible by 3 or 4)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org