You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/03/15 00:51:12 UTC
[GitHub] zeppelin pull request #2137: [ZEPPELIN-2260] Skip node,npm install and bundl...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2137
[ZEPPELIN-2260] Skip node,npm install and bundle when no helium package is selected
### What is this PR for?
Zeppelin 0.7.0 installs node and npm when it first starts for Helium package.
To be installed, or to failed to be installed due to network timeout, it takes some times.
We can just create empty file when no Helium package is enabled, instead of install npm and build bundle.
See discussion https://github.com/apache/zeppelin/pull/2095#issuecomment-285447619
### What type of PR is it?
Improvement
### Todos
* [x] - skip node,npm install and bundle package when no package is selected
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2260
### How should this be tested?
When no package is selected (e.g. right after clean install Zeppelin), npm and node is no longer installed on startup.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2137
----
commit 520ad3f0eb2e17bdbf5413cfb3f55bcff181e749
Author: Lee moon soo <mo...@apache.org>
Date: 2017-03-15T00:48:40Z
Skip node,npm install and bundle when no helium package is selected
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2137
You can set `ZEPPELIN_HELIUM_REGISTRY` environment variable in `conf/zeppelin-env.sh` or `zeppelin.helium.registry` property in `conf/zeppelin-site.xml`.
[Default value](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L629) is `helium,https://s3.amazonaws.com/helium-package/helium.json`, (a local dir and a remote registry).
If you change this value to `helium`, then Zeppelin will check only the local directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by FRosner <gi...@git.apache.org>.
Github user FRosner commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Ok @Leemoonsoo. So what does this PR actually do if it still waits 2 minutes now at a different stage? Or can I somehow prevent Zeppelin from getting the available helium package list?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2137
FYI, @NohSeho
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Thanks @FRosner reviewing the PR.
> ``` INFO [2017-03-15 10:41:22,547] ({main} Helium.java[loadConf]:114) - Add helium local registry /usr/local/zeppelin/helium
> INFO [2017-03-15 10:41:22,548] ({main} Helium.java[loadConf]:111) - Add helium online registry https://s3.amazonaws.com/helium-package/helium.json
> WARN [2017-03-15 10:41:22,552] ({main} Helium.java[loadConf]:122) - /usr/local/zeppelin/conf/helium.json does not exists
> ERROR [2017-03-15 10:43:30,270] ({main} HeliumOnlineRegistry.java[getAll]:73) - Connect to s3.amazonaws.com:443 [s3.amazonaws.com/52.216.82.43] failed: Connection timed out (Connection timed out)
> ```
Zeppelin tries to download available helium package list (which is filtered list of npm and maven registry). The new error is related with this process. This is a bit different issue and let me try solve it in different PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2137: [ZEPPELIN-2260] Skip node,npm install and bundl...
Posted by Leemoonsoo <gi...@git.apache.org>.
GitHub user Leemoonsoo reopened a pull request:
https://github.com/apache/zeppelin/pull/2137
[ZEPPELIN-2260] Skip node,npm install and bundle when no helium package is selected
### What is this PR for?
Zeppelin 0.7.0 installs node and npm when it first starts for Helium package.
To be installed, or to failed to be installed due to network timeout, it takes some times.
We can just create empty file when no Helium package is enabled, instead of install npm and build bundle.
See discussion https://github.com/apache/zeppelin/pull/2095#issuecomment-285447619
### What type of PR is it?
Improvement
### Todos
* [x] - skip node,npm install and bundle package when no package is selected
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2260
### How should this be tested?
When no package is selected (e.g. right after clean install Zeppelin), npm and node is no longer installed on startup.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2137
----
commit 520ad3f0eb2e17bdbf5413cfb3f55bcff181e749
Author: Lee moon soo <mo...@apache.org>
Date: 2017-03-15T00:48:40Z
Skip node,npm install and bundle when no helium package is selected
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by FRosner <gi...@git.apache.org>.
Github user FRosner commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Hi @Leemoonsoo,
I built your branch (https://travis-ci.org/FRosner/docker-zeppelin/builds/211271444) and tried it. However, it still waits for 2 minutes, now with a different 'error':
```
INFO [2017-03-15 10:41:22,547] ({main} Helium.java[loadConf]:114) - Add helium local registry /usr/local/zeppelin/helium
INFO [2017-03-15 10:41:22,548] ({main} Helium.java[loadConf]:111) - Add helium online registry https://s3.amazonaws.com/helium-package/helium.json
WARN [2017-03-15 10:41:22,552] ({main} Helium.java[loadConf]:122) - /usr/local/zeppelin/conf/helium.json does not exists
ERROR [2017-03-15 10:43:30,270] ({main} HeliumOnlineRegistry.java[getAll]:73) - Connect to s3.amazonaws.com:443 [s3.amazonaws.com/52.216.82.43] failed: Connection timed out (Connection timed out)
```
For your convenience, the previous 'error' was:
```
INFO [2017-03-07 12:52:34,068] ({main} NPMInstaller.java[installNpm]:117) - Installing npm version 3.10.8
INFO [2017-03-07 12:52:34,070] ({main} NPMInstaller.java[downloadFile]:198) - Downloading http://registry.npmjs.org/npm/-/npm-3.10.8.tgz to /usr/local/zeppelin/local-repo/vis/cache/npm-3.10.8.tar.gz
INFO [2017-03-07 12:52:34,074] ({main} ProxyConfig.java[getProxyForUrl]:27) - No proxies configured
INFO [2017-03-07 12:52:34,074] ({main} FileDownloader.java[execute]:91) - No proxy was configured, downloading directly
ERROR [2017-03-07 12:54:41,887] ({main} HeliumVisualizationFactory.java[installNodeAndNpm]:92) - Could not download npm
com.github.eirslett.maven.plugins.frontend.lib.InstallationException: Could not download npm
```
What is the way to "not select a helium package" so it does not try to download? What am I doing wrong?
Thanks
Frank
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by FRosner <gi...@git.apache.org>.
Github user FRosner commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Works like a charm @Leemoonsoo, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2137: [ZEPPELIN-2260] Skip node,npm install and bundl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2137: [ZEPPELIN-2260] Skip node,npm install and bundl...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2137
Merge to master if no further comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2137: [ZEPPELIN-2260] Skip node,npm install and bundle when ...
Posted by FRosner <gi...@git.apache.org>.
Github user FRosner commented on the issue:
https://github.com/apache/zeppelin/pull/2137
LGTM. I'm gonna build it today and give it a shot. I'll let you know how it went :)
Thanks @Leemoonsoo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---