[GitHub] [hive] amansinha100 commented on pull request #2823: HIVE-25749: Check if RelMetadataQuery.collations() returns null to av…

[GitBox <gi...@apache.org>]

amansinha100 commented on pull request #2823:
URL: https://github.com/apache/hive/pull/2823#issuecomment-981891264


   +1 
   I verified manually against a TPC-DS SF1 dataset that I have locally where the following query was previously hitting NPE and it works ok with this change. 
   
   Explain CBO
   with my_customers as (
    select distinct c_customer_sk
           , c_current_addr_sk
    from   
           ( select cs_sold_date_sk sold_date_sk,
                    cs_bill_customer_sk customer_sk,
                    cs_item_sk item_sk
             from   catalog_sales
             union all
             select ws_sold_date_sk sold_date_sk,
                    ws_bill_customer_sk customer_sk,
                    ws_item_sk item_sk
             from   web_sales
            ) cs_or_ws_sales,
            item,
            date_dim,
            customer
    where   sold_date_sk = d_date_sk
            and item_sk = i_item_sk
            and i_category = 'Books'
            and i_class = 'business'
            and c_customer_sk = cs_or_ws_sales.customer_sk
            and d_moy = 2
            and d_year = 2000
    )
   select * from my_customers;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org