[GitHub] [hudi] cuibo01 commented on a change in pull request #4699: [HUDI-3336][HUDI-FLINK] Support custom hadoop config options for flink

[GitBox <gi...@apache.org>]

cuibo01 commented on a change in pull request #4699:
URL: https://github.com/apache/hudi/pull/4699#discussion_r803565925



##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -660,25 +661,18 @@ private FlinkOptions() {
   // Prefix for Hoodie specific properties.
   private static final String PROPERTIES_PREFIX = "properties.";
 
-  /**
-   * Collects the config options that start with 'properties.' into a 'key'='value' list.
-   */
-  public static Map<String, String> getHoodieProperties(Map<String, String> options) {
-    return getHoodiePropertiesWithPrefix(options, PROPERTIES_PREFIX);
-  }
-
   /**
    * Collects the config options that start with specified prefix {@code prefix} into a 'key'='value' list.
    */
-  public static Map<String, String> getHoodiePropertiesWithPrefix(Map<String, String> options, String prefix) {
+  public static Map<String, String> getPropertiesWithPrefix(Map<String, String> options, String subprefix) {
     final Map<String, String> hoodieProperties = new HashMap<>();

Review comment:
       Parqurt also uses the `getHoodiePropertiesWithPrefix`, but the `getHoodiePropertiesWithPrefix` only use `properties.`, not append `parqurt`. To ensure consistency, hadoop and parquet add prefix(`properties.`) .
   `properties.parqurt.*` and `parqurt.*`, which one you think is better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org