You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/20 09:39:22 UTC

[GitHub] [cloudstack] jbampton commented on a diff in pull request #6273: Add `pre-commit` workflow with 3 Git hooks

jbampton commented on code in PR #6273:
URL: https://github.com/apache/cloudstack/pull/6273#discussion_r1053106121


##########
server/src/test/resources/db.properties:
##########
@@ -17,7 +17,7 @@
 
 
 # management server clustering parameters, change cluster.node.IP to the machine IP address
-# in which the management server is running
+# in which the management server is running
 cluster.node.IP=127.0.0.1
 cluster.servlet.port=9090

Review Comment:
   I found an issue thread here https://github.com/pre-commit/pre-commit-hooks/issues/196
   which talks about the 50/50 rule and how to fix the line endings locally.
   
   So that file had mostly Windows style carriage returns so did not get fixed at first.  
   Now I have just targeted Java and Python files for this initial first run clean up.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org