[GitHub] [iotdb] neuyilan commented on a change in pull request #2483: Add authentication in the node tool and modify the node tools doc

[GitBox <gi...@apache.org>]

neuyilan commented on a change in pull request #2483:
URL: https://github.com/apache/iotdb/pull/2483#discussion_r556995599



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/utils/nodetool/function/NodeToolCmd.java
##########
@@ -72,7 +83,9 @@ private MBeanServerConnection connect() {
     try {
       String jmxURL = String.format(JMX_URL_FORMAT, host, port);
       JMXServiceURL serviceURL = new JMXServiceURL(jmxURL);
-      JMXConnector connector = JMXConnectorFactory.connect(serviceURL);
+      Map<String, Object> environment = new HashMap<>(1);

Review comment:
       Thanks for your remind, i'll change it

##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/utils/nodetool/function/NodeToolCmd.java
##########
@@ -84,7 +97,7 @@ private MBeanServerConnection connect() {
     return mbsc;
   }
 
-  String nodeToString(Node node){
+  String nodeToString(Node node) {
     return String.format("%s:%d:%d", node.getIp(), node.getMetaPort(), node.getDataPort());

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org