[GitHub] apeforest commented on a change in pull request #12594: [MXNET-867] Pooling1D with "same" padding

[GitBox <gi...@apache.org>]

apeforest commented on a change in pull request #12594: [MXNET-867] Pooling1D with "same" padding
URL: https://github.com/apache/incubator-mxnet/pull/12594#discussion_r219384312
 
 

 ##########
 File path: src/operator/nn/pooling.cc
 ##########
 @@ -96,6 +96,11 @@ static bool PoolingShape(const nnvm::NodeAttrs &attrs,
     CHECK(param.p_value.has_value());
   }
   const TShape &dshape = (*in_shape)[0];
+  if (param.pooling_convention == pool_enum::kSame) {
+    CHECK_EQ(dshape.ndim(), 3U)
+      << "Pooling: Input data should be 3D in (batch, channel, x)"
+      << ", Currently 'same' supports Max Pooling 1-D";
 
 Review comment:
   nit: change coma to period.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services