You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/15 10:20:08 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #12626: ARROW-15896: [Python][C++] Add errno detail for filesystem "file not found" errors

pitrou commented on a change in pull request #12626:
URL: https://github.com/apache/arrow/pull/12626#discussion_r826801742



##########
File path: cpp/src/arrow/util/io_util.cc
##########
@@ -230,6 +230,31 @@ class ErrnoDetail : public StatusDetail {
 #if _WIN32
 const char kWinErrorDetailTypeId[] = "arrow::WinErrorDetail";
 
+// Map from a Windows error code to a `errno` value
+int WinErrorToErrno(int errnum) {
+  // NOTE there's a more complete mapping in the UCRT source code
+  // (in misc/errno.cpp) but it's not under an open source license

Review comment:
       Note to self: we could instead copy the code from Python's `errmap.h` file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org