You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/08 06:34:52 UTC
[GitHub] [superset] codecov[bot] commented on pull request #14014: fix(sqla): apply sqla type on calculated columns
codecov[bot] commented on pull request #14014:
URL: https://github.com/apache/superset/pull/14014#issuecomment-815489860
# [Codecov](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=h1) Report
> Merging [#14014](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=desc) (629448b) into [master](https://codecov.io/gh/apache/superset/commit/56dc74e09f1665c1030a8e6ccf66e27fb4f24e9b?el=desc) (56dc74e) will **decrease** coverage by `0.11%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 629448b differs from pull request most recent head aa604a4. Consider uploading reports for the commit aa604a4 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14014 +/- ##
==========================================
- Coverage 78.87% 78.76% -0.12%
==========================================
Files 936 936
Lines 47408 47381 -27
Branches 5941 5938 -3
==========================================
- Hits 37393 37318 -75
- Misses 9883 9937 +54
+ Partials 132 126 -6
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.17% <100.00%> (-0.99%)` | :arrow_down: |
| sqlite | `80.17% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/components/IndeterminateCheckbox/index.tsx](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94L2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ntend/src/dashboard/components/CssEditor/index.jsx](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci9pbmRleC5qc3g=) | `95.83% <ø> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...ols/MetricControl/AdhocMetricEditPopover/index.jsx](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIvaW5kZXguanN4) | `84.09% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `98.21% <100.00%> (+1.78%)` | :arrow_up: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `62.96% <100.00%> (-0.28%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.07% <100.00%> (-1.70%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-82.15%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.37% <0.00%> (-60.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [62 more](https://codecov.io/gh/apache/superset/pull/14014/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=footer). Last update [56dc74e...aa604a4](https://codecov.io/gh/apache/superset/pull/14014?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org