You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2003/04/04 15:42:26 UTC

cvs commit: httpd-2.0/modules/experimental mod_auth_ldap.c util_ldap.c

trawick     2003/04/04 05:42:26

  Modified:    modules/experimental mod_auth_ldap.c util_ldap.c
  Log:
  I don't think we're ready for C++/c89 slash-slash comments
  
  Revision  Changes    Path
  1.14      +1 -1      httpd-2.0/modules/experimental/mod_auth_ldap.c
  
  Index: mod_auth_ldap.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_auth_ldap.c,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- mod_auth_ldap.c	26 Mar 2003 19:31:26 -0000	1.13
  +++ mod_auth_ldap.c	4 Apr 2003 13:42:26 -0000	1.14
  @@ -153,7 +153,7 @@
       int check_short = 0;
       char *charset;
       
  -    if (!language)          // our default codepage
  +    if (!language)          /* our default codepage */
           return apr_pstrdup(p, "ISO-8859-1");
       else
           lang_len = strlen(language);
  
  
  
  1.13      +1 -1      httpd-2.0/modules/experimental/util_ldap.c
  
  Index: util_ldap.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/experimental/util_ldap.c,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- util_ldap.c	24 Feb 2003 23:19:30 -0000	1.12
  +++ util_ldap.c	4 Apr 2003 13:42:26 -0000	1.13
  @@ -441,7 +441,7 @@
       }
   
   /* artificially disable cache */
  -//l = NULL;
  +l = NULL;
   
       /* If no connection what found after the second search, we
        * must create one.
  
  
  

Re: cvs commit: httpd-2.0/modules/experimental mod_auth_ldap.c util_ldap.c

Posted by Jeff Trawick <tr...@attglobal.net>.
Graham Leggett wrote:
> trawick@apache.org wrote:
> 
>>    /* artificially disable cache */
>>   -//l = NULL;
>>   +l = NULL;
> 
> 
> This change just commented back in behaviour that had been commented out 
> - can you surround this one with /* instead?

fixed, thanks (blush)



Re: cvs commit: httpd-2.0/modules/experimental mod_auth_ldap.c util_ldap.c

Posted by Graham Leggett <mi...@sharp.fm>.
trawick@apache.org wrote:

>    /* artificially disable cache */
>   -//l = NULL;
>   +l = NULL;

This change just commented back in behaviour that had been commented out 
- can you surround this one with /* instead?

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."


Re: cvs commit: httpd-2.0/modules/experimental mod_auth_ldap.c util_ldap.c

Posted by Jeff Trawick <tr...@attglobal.net>.
trawick@apache.org wrote:
> trawick     2003/04/04 05:42:26
> 
>   Modified:    modules/experimental mod_auth_ldap.c util_ldap.c
>   Log:
>   I don't think we're ready for C++/c89 slash-slash comments

just to clarify: beyond any mere style issues, this is something that 
affects the user community, since some non-c99 compilers have to be told 
explicitly to allow // comments, and not all users are up to recognizing 
that a compiler-specific tweak to CFLAGS is necessary to get them 
building again


Re: cvs commit: httpd-2.0/modules/experimental mod_auth_ldap.c util_ldap.c

Posted by Graham Leggett <mi...@sharp.fm>.
trawick@apache.org wrote:

>    /* artificially disable cache */
>   -//l = NULL;
>   +l = NULL;

This change just commented back in behaviour that had been commented out 
- can you surround this one with /* instead?

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."