You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jychen7 (via GitHub)" <gi...@apache.org> on 2023/02/02 22:56:55 UTC

[GitHub] [arrow-rs] jychen7 commented on issue #3651: object_store: support encoded path

jychen7 commented on issue #3651:
URL: https://github.com/apache/arrow-rs/issues/3651#issuecomment-1414483081

   @tustvold yes, I have tried.
   
   I understand that `Path::parse("blogs%20space.parquet")` will NOT re-encode, the result is `Path { raw: "blogs%20space.parquet" }`.
   
   However, when client GET object, it will re-encode at L246 -> L211 -> L459 below
   https://github.com/apache/arrow-rs/blob/2b9bbce44abbd93048c674f49c4eb0db72a0a1c8/object_store/src/aws/client.rs#L237-L246
   https://github.com/apache/arrow-rs/blob/2b9bbce44abbd93048c674f49c4eb0db72a0a1c8/object_store/src/aws/client.rs#L209-L213
   https://github.com/apache/arrow-rs/blob/2b9bbce44abbd93048c674f49c4eb0db72a0a1c8/object_store/src/aws/client.rs#L458-L460
   
   I imagine L211 need to know whether input `Path` is already encoded, either via new attribute or auto detect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org