[GitHub] incubator-weex pull request #1096: fixed textfield menuController delete cas...

[Jsonmess <gi...@git.apache.org>]

GitHub user Jsonmess opened a pull request:

    https://github.com/apache/incubator-weex/pull/1096

    fixed textfield menuController delete case crash

    First of all, thank you for your contribution! 
    
    Please makes sure that these checkboxes are checked before submitting your PR, thank you!
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.
    *  [ios] fixed WXTextInputView MenuController  menu item  "unrecognized selector sent to instance" like "delete" in protocol "UIResponderStandardEditActions"
    
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jsonmess/incubator-weex fixed-uitextfieldMenuIssue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1096
    
----
commit 28d34095dba860439b2e271e4c847befe97815b2
Author: zhutong <zh...@...>
Date:   2018-04-02T03:58:24Z

    fixed textfield menuController delete case crash

----


---

[GitHub] incubator-weex issue #1096: [WEEX-277][iOS]fixed textfield menuController de...

[acton393 <gi...@git.apache.org>]

Github user acton393 commented on the issue:

    https://github.com/apache/incubator-weex/pull/1096
  
    @Jsonmess  thank you for fixing the bug , it will be accepted.


---

[GitHub] incubator-weex pull request #1096: [WEEX-277][iOS]fixed textfield menuContro...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1096


---

[GitHub] incubator-weex issue #1096: fixed textfield menuController delete case crash

[weex-bot <gi...@git.apache.org>]

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1096
  
    
    <!--
      0 failure: 
      0 warning: 
      2 messages
      
    -->
    
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>has no jsfm file changed.</td>
        </tr>
      
    <tr>
          <td>:book:</td>
          <td>jsfm test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex issue #1096: [iOS]fixed textfield menuController delete case ...

[Jsonmess <gi...@git.apache.org>]

Github user Jsonmess commented on the issue:

    https://github.com/apache/incubator-weex/pull/1096
  
    i am not implement UITextField "delete", because i think "delete" not useful. people have not behavior to use menu item "delete" to delete their input text.


---

[GitHub] incubator-weex issue #1096: [iOS]fixed textfield menuController delete case ...

[acton393 <gi...@git.apache.org>]

Github user acton393 commented on the issue:

    https://github.com/apache/incubator-weex/pull/1096
  
    hi  @Jsonmess  thank you for your contribution,  you can follow the [development-process](http://weex.apache.org/development-process.html)  to update your pull request


---