[GitHub] [airflow] potiuk commented on a change in pull request #10526: Remove unreachable code in test_user_command.py

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #10526:
URL: https://github.com/apache/airflow/pull/10526#discussion_r475911788



##########
File path: tests/cli/commands/test_user_command.py
##########
@@ -177,7 +177,6 @@ def find_by_username(username):
             matches = [u for u in retrieved_users if u['username'] == username]
             if not matches:
                 self.fail("Couldn't find user with username {}".format(username))
-                return None

Review comment:
       I think it's reachable in fact. Simply IntelliJ thinks it's not (because of the "fail" name for some reason). But this is a "normal" method, so it needs # noqa so that IntelliJ's false positive is silenced.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org