You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/02/10 08:30:23 UTC
[GitHub] [pinot] ankitsultana opened a new issue #8187: API for Fetching Live Brokers of a Table Doesn't Support Table Names without Type Suffix
ankitsultana opened a new issue #8187:
URL: https://github.com/apache/pinot/issues/8187
At present the `/tables/{tableNameWithType}/livebrokers` API doesn't support table names without the type suffix. Upstream callers that are not aware of the available types for a given table will have to try the API for both the table-types to determine the available brokers.
We can either update the existing API to handle tables names without type or add a new API. Updating the existing API would inevitably change the behavior of the API so it can cause compatibility issues.
This was also discussed in the PR for adding the livebrokers API as a follow-up: https://github.com/apache/pinot/pull/7556/commits/e2e3aebab2712accc15190d6d3984b7c9e6de5d7#r738959901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] chenboat closed issue #8187: API for Fetching Live Brokers of a Table Doesn't Support Table Names without Type Suffix
Posted by GitBox <gi...@apache.org>.
chenboat closed issue #8187:
URL: https://github.com/apache/pinot/issues/8187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #8187: API for Fetching Live Brokers of a Table Doesn't Support Table Names without Type Suffix
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #8187:
URL: https://github.com/apache/pinot/issues/8187#issuecomment-1035528134
Let's change the existing API to take table name (with or without type suffix).
- If type suffix is provided, we follow the existing behavior
- If type suffix is not provided, check the table existence. If only one of OFFLINE/REALTIME table exists, follow the existing behavior; if both table exists, return the intersection of the hosts
@chenboat Do you agree on the proposed change? I remember suggesting this behavior in the original PR, but we decided to do it later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] chenboat commented on issue #8187: API for Fetching Live Brokers of a Table Doesn't Support Table Names without Type Suffix
Posted by GitBox <gi...@apache.org>.
chenboat commented on issue #8187:
URL: https://github.com/apache/pinot/issues/8187#issuecomment-1036518824
@Jackie-Jiang Your proposal looks fine to me. I want to make sure the change is backward compatible. i.e., the type suffix can be an optional query parameter. we will fall back to the current behavior if it is present. cc @ankitsultana
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org