You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ulysses-you (via GitHub)" <gi...@apache.org> on 2023/03/10 10:24:28 UTC
[GitHub] [spark] ulysses-you commented on pull request #40364: [SPARK-42745][SQL] Improved AliasAwareOutputExpression works with DSv2
ulysses-you commented on PR #40364:
URL: https://github.com/apache/spark/pull/40364#issuecomment-1463591644
it seems to me that:
1. we should skip add `PlanExpression` into `aliasMap`
2. make `aliasMap` as immutable, and use a local mutable map, then merge them after done multiTransform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org