You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/28 19:51:49 UTC
[GitHub] [camel-k] phantomjinx opened a new pull request, #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
phantomjinx opened a new pull request, #3245:
URL: https://github.com/apache/camel-k/pull/3245
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
Using `kamel install -v debug`, it is now possible to switch on debug logging messages in the operator pod log. The `-v` switch has the effect of adding an environment variable (LOG_LEVEL) to the operator deployment resource. The value of this variable can be either `info`, `debug` or an integer.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#issuecomment-1113446214
> There is some lint complains. The other E2E failures looks to be something failing in general and we must fix anyway.
Hopefully fixed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#discussion_r861621833
##########
pkg/cmd/install.go:
##########
@@ -142,6 +142,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *installCmdO
cmd.Flags().StringArray("node-selector", nil, "Add a NodeSelector to the operator Pod")
cmd.Flags().StringArray("operator-resources", nil, "Define the resources requests and limits assigned to the operator Pod as <requestType.requestResource=value> (i.e., limits.memory=256Mi)")
cmd.Flags().StringArray("operator-env-vars", nil, "Add an environment variable to set in the operator Pod(s), as <name=value>")
+ cmd.Flags().StringP("log-level", "v", "info", "The level of operator logging (default - info): info or 0, debug or 1")
Review Comment:
Good one spotted. In any case I think we can have each subcommand to handle its own flags, but I don't have a strong opinion on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on a diff in pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on code in PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#discussion_r861911983
##########
pkg/cmd/install.go:
##########
@@ -142,6 +142,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *installCmdO
cmd.Flags().StringArray("node-selector", nil, "Add a NodeSelector to the operator Pod")
cmd.Flags().StringArray("operator-resources", nil, "Define the resources requests and limits assigned to the operator Pod as <requestType.requestResource=value> (i.e., limits.memory=256Mi)")
cmd.Flags().StringArray("operator-env-vars", nil, "Add an environment variable to set in the operator Pod(s), as <name=value>")
+ cmd.Flags().StringP("log-level", "v", "info", "The level of operator logging (default - info): info or 0, debug or 1")
Review Comment:
Changed letter to `-z` seeing as its log-level, ie. pretty rarely used switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on a diff in pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on code in PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#discussion_r861719863
##########
pkg/cmd/install.go:
##########
@@ -142,6 +142,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *installCmdO
cmd.Flags().StringArray("node-selector", nil, "Add a NodeSelector to the operator Pod")
cmd.Flags().StringArray("operator-resources", nil, "Define the resources requests and limits assigned to the operator Pod as <requestType.requestResource=value> (i.e., limits.memory=256Mi)")
cmd.Flags().StringArray("operator-env-vars", nil, "Add an environment variable to set in the operator Pod(s), as <name=value>")
+ cmd.Flags().StringP("log-level", "v", "info", "The level of operator logging (default - info): info or 0, debug or 1")
Review Comment:
I'll change the letter. Didn't notice the overloading. Thanks @tadayosi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#issuecomment-1116062313
> Tests seems to be failing, not only upgrade.
Yes, there is already something else broken on `main`. I'll merge this as it partially fixes things. Later we should focus on what else is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#discussion_r861621469
##########
pkg/cmd/install.go:
##########
@@ -142,6 +142,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *installCmdO
cmd.Flags().StringArray("node-selector", nil, "Add a NodeSelector to the operator Pod")
cmd.Flags().StringArray("operator-resources", nil, "Define the resources requests and limits assigned to the operator Pod as <requestType.requestResource=value> (i.e., limits.memory=256Mi)")
cmd.Flags().StringArray("operator-env-vars", nil, "Add an environment variable to set in the operator Pod(s), as <name=value>")
+ cmd.Flags().StringP("log-level", "v", "info", "The level of operator logging (default - info): info or 0, debug or 1")
Review Comment:
Also, at #3193 @johnpoth is introducing `--verbose` flag for `kamel run`. Is it something we can provide consistency for those similar functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#issuecomment-1113562917
I believe https://github.com/apache/camel-k/issues/3246 is what is making the Upgrade test fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#discussion_r861616889
##########
pkg/cmd/install.go:
##########
@@ -142,6 +142,7 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *installCmdO
cmd.Flags().StringArray("node-selector", nil, "Add a NodeSelector to the operator Pod")
cmd.Flags().StringArray("operator-resources", nil, "Define the resources requests and limits assigned to the operator Pod as <requestType.requestResource=value> (i.e., limits.memory=256Mi)")
cmd.Flags().StringArray("operator-env-vars", nil, "Add an environment variable to set in the operator Pod(s), as <name=value>")
+ cmd.Flags().StringP("log-level", "v", "info", "The level of operator logging (default - info): info or 0, debug or 1")
Review Comment:
In `kamel run`, `-v` is already used for volume. For consistency throughout cli isn't it good idea to avoid overloading of short flags and use a different one? For example, what about using `-V` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#issuecomment-1116001952
Tests seems to be failing, not only upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3245:
URL: https://github.com/apache/camel-k/pull/3245#issuecomment-1116167329
Let me know when we want to start release 1.9.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3245: #3053 #3242 Fixes e2e preflight and adds debug level to logging
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3245:
URL: https://github.com/apache/camel-k/pull/3245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org