You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/26 19:15:17 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
xiaoxiang781216 opened a new pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625
## Summary
Since the enable status keep stable in [a|d]joy_sample.
- input/djoystick: Remove the unused config field from djoy_lowerhalf_s
- input/ajoystck: Remove ajoy_enable from ajoy_sample
- input/djoystck: Remove djoy_enable from djoy_sample
## Impact
No
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625#issuecomment-1053597780
> I think this change will be valid only after #5204 is merged.
@pkarashchenko the change is independent with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625#issuecomment-1053605271
Currently `ajoy_enable` is called from `ajoy_sample` that is called from `ajoy_interrupt`. Also `ajoy_enable` is called from `ajoy_ioctl` for example. You are trying to fix resource protection in https://github.com/apache/incubator-nuttx/pull/5204 so currently the timing might lead to interrupt fire during `opriv->ao_pollevents` modification in `ajoy_ioctl`.
I really think that your change are correct, however I also think that there still is some dependency on `https://github.com/apache/incubator-nuttx/pull/5204`. It is not sequential dependency, I agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625#issuecomment-1052594450
@xiaoxiang781216 will it support the case with a device have more than one joystick, like the joysticks with two analog XY potentiometer or even analog + digital in the same device?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625#issuecomment-1052606100
> @xiaoxiang781216 will it support the case with a device have more than one joystick, like the joysticks with two analog XY potentiometer or even analog + digital in the same device?
The change doesn't modify the behavior, just remove the redundant call since it's no-op to call [a|d]joy_enable if no setting change:
https://github.com/apache/incubator-nuttx/pull/5625/files#diff-5803ad0a8a93175597d14948ffe9a46f4e1ad28b59d28bcb568f56553b1fa8f7R195-R215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5625: joystick: Remove [a|d]joy_enable from [a|d]joy_sample
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5625:
URL: https://github.com/apache/incubator-nuttx/pull/5625#issuecomment-1053589085
I think this change will be valid only after https://github.com/apache/incubator-nuttx/pull/5204 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org