You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/02/04 21:10:51 UTC

[jira] [Commented] (MSHARED-611) Drop any href validation and pass as-is

    [ https://issues.apache.org/jira/browse/MSHARED-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15852932#comment-15852932 ] 

Hudson commented on MSHARED-611:
--------------------------------

SUCCESS: Integrated in Jenkins build maven-shared #3594 (See [https://builds.apache.org/job/maven-shared/3594/])
[MSHARED-611] Drop any href validation and pass as-is (michaelo: [http://svn.apache.org/viewvc/?view=rev&rev=1781702])
* (edit) maven-reporting-impl/pom.xml
* (edit) maven-reporting-impl/src/main/java/org/apache/maven/reporting/AbstractMavenReportRenderer.java
* (delete) maven-reporting-impl/src/main/java/org/apache/maven/reporting/UrlValidationUtil.java
* (delete) maven-reporting-impl/src/test/java/org/apache/maven/reporting/UrlValidationUtilTest.java


> Drop any href validation and pass as-is
> ---------------------------------------
>
>                 Key: MSHARED-611
>                 URL: https://issues.apache.org/jira/browse/MSHARED-611
>             Project: Maven Shared Components
>          Issue Type: Task
>          Components: maven-reporting-impl
>    Affects Versions: maven-reporting-impl 2.4
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>             Fix For: maven-reporting-impl 3.0
>
>
> The current href validation causes several issues, e.g., MSHARED-609, or just the fact that we are not able to properly validate valid links/hrefs because there is a too broad variety of schemes and styles. We can use at most {{java.net.URI}}, but still HTML's {{href}} is far more permissive. At the end, we drop valid values like {{ssh://}}, {{sftp://}}, {{smb://}}, {{s3://}}, and many more without even telling the user.
> We shall stop doing that and simply pass the value as-is, the {{href}} is now at the discretion of the site author.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)