[GitHub] [incubator-nuttx] no1wudi commented on pull request #3626: libc: Move pthread staff to userspace

[GitBox <gi...@apache.org>]

no1wudi commented on pull request #3626:
URL: https://github.com/apache/incubator-nuttx/pull/3626#issuecomment-829281942


   > I think there is an error in the title. Did you mean stuff instead of staff?
   > 
   > There is logic on the branch feature/pthread-user that also implements moving pthread_create and pthread_exit to libs/libc/pthread. See https://github.com/apache/incubator-nuttx/tree/feature/pthread-user and PR #1328.
   > 
   > ```
   > The primary objective here was:
   > 
   > 1. To eliminate security problems when pthread_cleanup_popall() is called when the pthread exits:  See Issue #1263 and #1328.  And
   > 2. Implement pthread thread-specific data destructors (mentioned in #1328)
   > 
   > It looks to me like this PR, takes much of its logic from that feature/pthread-user branch.  If/when this PR is merged, I will remove the branch, and close the issue and PR.
   > ```
   
   The main logic in this PR is just picked from feature/pthread_user with little modification
   
   And, now os call the pthread_cleanup from user space in pthread_exit, but in pthread_cancel they are still called from kernel side, we still need to move cancellation to user space.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org