You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2011/10/17 11:10:12 UTC
[jira] [Created] (BOOKKEEPER-83) Added versioning and flags to the
bookie protocol
Added versioning and flags to the bookie protocol
-------------------------------------------------
Key: BOOKKEEPER-83
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
Project: Bookkeeper
Issue Type: Improvement
Reporter: Ivan Kelly
Fix For: 3.4.0
There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-83) Added versioning and flags to
the bookie protocol
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137029#comment-13137029 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-83:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2401/#review2876
-----------------------------------------------------------
Ship it!
There is just a tiny typo that we could consider doing. We can even fix it upon commit instead of making you generate a new patch.
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
<https://reviews.apache.org/r/2401/#comment6432>
We could fix the typo here... :-)
- fpj
On 2011-10-17 14:02:54, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2401/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-17 14:02:54)
bq.
bq.
bq. Review request for bookkeeper, fpj and Benjamin Reed.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
bq.
bq.
bq. This addresses bug BOOKKEEPER-83.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-83
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java eb76a1d
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java 63084a8
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java 1ff135b
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java b38604a
bq. bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 9141067
bq. bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestProtoVersions.java PRE-CREATION
bq. bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java 4cfaf30
bq.
bq. Diff: https://reviews.apache.org/r/2401/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
> Key: BOOKKEEPER-83
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-83) Added versioning and flags to the
bookie protocol
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-83:
---------------------------------
Attachment: BOOKKEEPER-83.diff
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
> Key: BOOKKEEPER-83
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-83) Added versioning and flags to
the bookie protocol
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136965#comment-13136965 ]
Flavio Junqueira commented on BOOKKEEPER-83:
--------------------------------------------
+1, looks good.
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
> Key: BOOKKEEPER-83
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-83) Added versioning and flags to
the bookie protocol
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128889#comment-13128889 ]
Ivan Kelly commented on BOOKKEEPER-83:
--------------------------------------
Border cases tested in patch. Protocol is compatible with current protocol. Also adds flags field which is needed for fencing.
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
> Key: BOOKKEEPER-83
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-83) Added versioning and flags to
the bookie protocol
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128890#comment-13128890 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-83:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2401/
-----------------------------------------------------------
Review request for bookkeeper, fpj and Benjamin Reed.
Summary
-------
There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
This addresses bug BOOKKEEPER-83.
https://issues.apache.org/jira/browse/BOOKKEEPER-83
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java eb76a1d
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java 63084a8
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java 1ff135b
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java b38604a
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 9141067
bookkeeper-server/src/test/java/org/apache/bookkeeper/proto/TestProtoVersions.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieClientTest.java 4cfaf30
Diff: https://reviews.apache.org/r/2401/diff
Testing
-------
Thanks,
Ivan
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
> Key: BOOKKEEPER-83
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-83) Added versioning and flags to the
bookie protocol
Posted by "Flavio Junqueira (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-83:
---------------------------------------
Assignee: Ivan Kelly
> Added versioning and flags to the bookie protocol
> -------------------------------------------------
>
> Key: BOOKKEEPER-83
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-83
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 3.4.0
>
> Attachments: BOOKKEEPER-83.diff
>
>
> There is no concept of versions in the BookKeeper protocol at the moment. This patch addresses that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira