Re: [PR] doc(readme): update github and npm version badges [cordova-android]

["erisu (via GitHub)" <gi...@apache.org>]

erisu commented on code in PR #1872:
URL: https://github.com/apache/cordova-android/pull/1872#discussion_r2640362922


##########
README.md:
##########
@@ -19,9 +19,7 @@
 #
 -->
 
-# Cordova Android
-
-[![NPM](https://nodei.co/npm/cordova-android.png)](https://nodei.co/npm/cordova-android/)
+# Cordova Android ![GitHub package.json version](https://img.shields.io/github/package-json/v/apache/cordova-android)

Review Comment:
   I don’t really have a strong opinion on `shields.io` versus `nodei.co`.
   
   While all of our other repositories currently use one of these services, it would be nice to be consistent. However, no single service supports all potential use cases, so mixing them might be acceptable.
   
   If you prefer to stick with `nodei.co` only, you may need to open a request in their GitHub repository to see whether they are willing to add the missing features.
   
   Regarding licensing: `shields.io` uses the `CC0-1.0` license, which I believe is acceptable. `nodei.co` is licensed under `MIT +no-false-attribs`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org