[GitHub] [beam] lostluck commented on a change in pull request #15482: [BEAM-11217] Implemented metrics filtering

[GitBox <gi...@apache.org>]

lostluck commented on a change in pull request #15482:
URL: https://github.com/apache/beam/pull/15482#discussion_r706375871



##########
File path: sdks/go/test/integration/metrics/metrics_test.go
##########
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package metrics

Review comment:
       As a rule, do not create test file only packages. They don't work as well as you might expect.
   
   Consider instead updating the existing integration tests to check their metrics instead of having a test for metrics by themselves. The point is to validate those pipelines are doing what we expect, and metrics are that tool.

##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -482,7 +482,75 @@ func (mr Results) AllMetrics() QueryResults {
 	return QueryResults{mr.counters, mr.distributions, mr.gauges}
 }
 
-// TODO(BEAM-11217): Implement Query(Filter) and metrics filtering
+// SingleResult interface facilitates metrics query filtering methods.
+type SingleResult interface {
+	Step() string
+	Name() string
+	Namespace() string
+}
+
+func (r CounterResult) Name() string {
+	return r.Key.Name
+}
+
+func (r CounterResult) Namespace() string {
+	return r.Key.Namespace
+}
+
+func (r CounterResult) Step() string {
+	return r.Key.Step
+}

Review comment:
       Please move theses definitions to where the CounterResult, etc types are defined.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org