You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/22 10:38:00 UTC
[jira] [Work logged] (BEAM-5193) KuduIO testWrite not correctly
verifying behaviour
[ https://issues.apache.org/jira/browse/BEAM-5193?focusedWorklogId=136888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136888 ]
ASF GitHub Bot logged work on BEAM-5193:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/18 10:37
Start Date: 22/Aug/18 10:37
Worklog Time Spent: 10m
Work Description: timrobertson100 opened a new pull request #6263: [BEAM-5193] Correct typos in KuduIOTest testWrite
URL: https://github.com/apache/beam/pull/6263
Corrects some typos which slipped in to the original Kudu commit in error and meant the kudu testWrite() was not doing what it was intended to do.
1) It has gone unnoticed presumably because test environments have had more than 3 processor cores. The intended design was to ensure only at least 3 which is the minimum parallelism that the DirectRunner will provide.
2) The second loop here was just a typo and never executed. This corrects that to verify behaviour.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 136888)
Time Spent: 10m
Remaining Estimate: 0h
> KuduIO testWrite not correctly verifying behaviour
> --------------------------------------------------
>
> Key: BEAM-5193
> URL: https://issues.apache.org/jira/browse/BEAM-5193
> Project: Beam
> Issue Type: Bug
> Components: io-ideas
> Affects Versions: 2.6.0
> Reporter: Tim Robertson
> Assignee: Tim Robertson
> Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{testWrite}} in {{KuduIOTest}} has 2 typos which were committed in error.
> The following code block
> {code:java}
> for (int i = 1; i <= targetParallelism + 1; i++) {
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
> }
> // verify all entries written
> for (int n = 0; n > numberRecords; n++) {
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
> }
> {code}
>
> Should have read:
> {code:java}
> for (int i = 1; i <= targetParallelism ; i++) {
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
> }
> // verify all entries written
> for (int n = 0; n < numberRecords; n++) {
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
> }
> {code}
> This has gone unnoticed because 1) the {{targetParallelism}} is a function of cores available, and the test uses 3 only (which is the min in {{DirectRunner}}) and 2) the incorrect {{>}} in the test simply meant the loop was not run.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)