You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chaoyu Tang <ct...@gmail.com> on 2015/10/24 18:48:34 UTC

Review Request 39624: HIVE-12245: Support column comments for an HBase backed table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39624/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-12245
    https://issues.apache.org/jira/browse/HIVE-12245


Repository: hive-git


Description
-------

The column comments of an HBase backed table should return their real values instead of the "from deserializer".


Diffs
-----

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java cb9f9d3 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 1adb913 
  hbase-handler/src/test/queries/positive/hbase_queries.q 6ef9325 
  hbase-handler/src/test/results/positive/external_table_ppd.q.out 83eb2f5 
  hbase-handler/src/test/results/positive/hbase_binary_storage_queries.q.out f212331 
  hbase-handler/src/test/results/positive/hbase_queries.q.out ce6e526 
  hbase-handler/src/test/results/positive/hbase_timestamp.q.out 538e551 
  hbase-handler/src/test/results/positive/hbase_timestamp_format.q.out 138cfe6 

Diff: https://reviews.apache.org/r/39624/diff/


Testing
-------

Local unit tests passed
submitted Precommit build.


Thanks,

Chaoyu Tang


Re: Review Request 39624: HIVE-12245: Support column comments for an HBase backed table

Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39624/
-----------------------------------------------------------

(Updated Oct. 27, 2015, 3:55 a.m.)


Review request for hive.


Bugs: HIVE-12245
    https://issues.apache.org/jira/browse/HIVE-12245


Repository: hive-git


Description
-------

The column comments of an HBase backed table should return their real values instead of the "from deserializer".


Diffs (updated)
-----

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java cb9f9d3 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 1adb913 
  hbase-handler/src/test/queries/positive/hbase_queries.q 6ef9325 
  hbase-handler/src/test/results/positive/external_table_ppd.q.out 83eb2f5 
  hbase-handler/src/test/results/positive/hbase_binary_storage_queries.q.out f212331 
  hbase-handler/src/test/results/positive/hbase_queries.q.out ce6e526 
  hbase-handler/src/test/results/positive/hbase_timestamp.q.out 538e551 
  hbase-handler/src/test/results/positive/hbase_timestamp_format.q.out 138cfe6 

Diff: https://reviews.apache.org/r/39624/diff/


Testing
-------

Local unit tests passed
submitted Precommit build.


Thanks,

Chaoyu Tang


Re: Review Request 39624: HIVE-12245: Support column comments for an HBase backed table

Posted by Chaoyu Tang <ct...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39624/
-----------------------------------------------------------

(Updated Oct. 27, 2015, 3:53 a.m.)


Review request for hive.


Changes
-------

patch with fixes to failed tests


Bugs: HIVE-12245
    https://issues.apache.org/jira/browse/HIVE-12245


Repository: hive-git


Description
-------

The column comments of an HBase backed table should return their real values instead of the "from deserializer".


Diffs (updated)
-----

  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseLazyObjectFactory.java cb9f9d3 
  hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseSerDe.java 1adb913 
  hbase-handler/src/test/queries/positive/hbase_queries.q 6ef9325 
  hbase-handler/src/test/results/positive/external_table_ppd.q.out 83eb2f5 
  hbase-handler/src/test/results/positive/hbase_binary_storage_queries.q.out f212331 
  hbase-handler/src/test/results/positive/hbase_queries.q.out ce6e526 
  hbase-handler/src/test/results/positive/hbase_timestamp.q.out 538e551 
  hbase-handler/src/test/results/positive/hbase_timestamp_format.q.out 138cfe6 

Diff: https://reviews.apache.org/r/39624/diff/


Testing
-------

Local unit tests passed
submitted Precommit build.


Thanks,

Chaoyu Tang