You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/02 03:20:24 UTC

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #333: fix: add name field when create route and upstream

codecov-io commented on pull request #333:
URL: https://github.com/apache/apisix-ingress-controller/pull/333#issuecomment-812295318


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=h1) Report
   > Merging [#333](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=desc) (ac9887f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/06e2b35bccbf62a9d7a1d0e2680eb9a71be78cae?el=desc) (06e2b35) will **increase** coverage by `0.67%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #333      +/-   ##
   ==========================================
   + Coverage   42.65%   43.32%   +0.67%     
   ==========================================
     Files          40       40              
     Lines        3418     3432      +14     
   ==========================================
   + Hits         1458     1487      +29     
   + Misses       1801     1775      -26     
   - Partials      159      170      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `42.76% <100.00%> (-0.46%)` | :arrow_down: |
   | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `46.85% <100.00%> (+0.61%)` | :arrow_up: |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `28.44% <0.00%> (-5.97%)` | :arrow_down: |
   | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `78.21% <0.00%> (+0.21%)` | :arrow_up: |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `47.36% <0.00%> (+17.17%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=footer). Last update [06e2b35...ac9887f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/333?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org