You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/30 02:06:35 UTC
[GitHub] [incubator-shenyu] yunlongn opened a new pull request, #3637: [ISSUE #3628] Signature plugin extension
yunlongn opened a new pull request, #3637:
URL: https://github.com/apache/incubator-shenyu/pull/3637
<!-- Describe your PR here; eg. Fixes #issueNo -->
Signature plugin extension
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #3637: [ISSUE #3628] Signature plugin extension
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3637:
URL: https://github.com/apache/incubator-shenyu/pull/3637#issuecomment-1172131483
# [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3637](https://codecov.io/gh/apache/incubator-shenyu/pull/3637?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4ddf9e) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/a27bb8f5ff2e17d9f8eef83030ad0429520cc364?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a27bb8f) will **decrease** coverage by `0.48%`.
> The diff coverage is `87.71%`.
> :exclamation: Current head f4ddf9e differs from pull request most recent head 6472312. Consider uploading reports for the commit 6472312 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3637 +/- ##
============================================
- Coverage 62.72% 62.23% -0.49%
+ Complexity 5868 5836 -32
============================================
Files 888 892 +4
Lines 24723 24784 +61
Branches 2263 2265 +2
============================================
- Hits 15507 15424 -83
- Misses 7763 7901 +138
- Partials 1453 1459 +6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/3637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...plugin/sign/subscriber/SignAuthDataSubscriber.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zdWJzY3JpYmVyL1NpZ25BdXRoRGF0YVN1YnNjcmliZXIuamF2YQ==) | `100.00% <ø> (+100.00%)` | :arrow_up: |
| [...java/org/apache/shenyu/common/utils/JsonUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9Kc29uVXRpbHMuamF2YQ==) | `67.44% <40.00%> (-3.62%)` | :arrow_down: |
| [...yu/plugin/sign/decorator/SignRequestDecorator.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9kZWNvcmF0b3IvU2lnblJlcXVlc3REZWNvcmF0b3IuamF2YQ==) | `66.66% <66.66%> (ø)` | |
| [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `93.75% <90.90%> (+33.75%)` | :arrow_up: |
| [...org/apache/shenyu/plugin/sign/api/SignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2lnblNlcnZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...nyu/plugin/sign/handler/SignPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9oYW5kbGVyL1NpZ25QbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...he/shenyu/plugin/sign/handler/SignRuleHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9oYW5kbGVyL1NpZ25SdWxlSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `92.45% <100.00%> (+14.90%)` | :arrow_up: |
| [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...henyu/plugin/logging/kafka/LoggingKafkaPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2xvZ2dpbmcva2Fma2EvTG9nZ2luZ0thZmthUGx1Z2luLmphdmE=) | `22.72% <0.00%> (-72.73%)` | :arrow_down: |
| ... and [64 more](https://codecov.io/gh/apache/incubator-shenyu/pull/3637/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3637?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/3637?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a27bb8f...6472312](https://codecov.io/gh/apache/incubator-shenyu/pull/3637?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 merged pull request #3637: [ISSUE #3628] Signature plugin extension
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3637:
URL: https://github.com/apache/incubator-shenyu/pull/3637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu] yu199195 commented on pull request #3637: [ISSUE #3628] Signature plugin extension
Posted by GitBox <gi...@apache.org>.
yu199195 commented on PR #3637:
URL: https://github.com/apache/incubator-shenyu/pull/3637#issuecomment-1173333678
@yunlongn Hi， looks good to me， you can add my wechat：13786298670， i will invate you to contributor group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org