You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/01 22:03:47 UTC

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.

rhoughton-pivot commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r605970632



##########
File path: geode-core/build.gradle
##########
@@ -320,6 +320,10 @@ dependencies {
     implementation(project(':geode-serialization'))
     implementation(project(':geode-tcp-server'))
 
+    runtimeOnly(project(':geode-deployment:geode-deployment-legacy')) {
+        ext.optional = true
+    }
+

Review comment:
       This declaration already exists on line 236, as a non-optional. With both in place, the result is a non-optional runtime dependency. Which is it?
   
   If we chose optional, we'll also need to modify `test/resources/expected-pom.xml`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org