[GitHub] drill issue #819: DRILL-5419: Calculate return string length for literals & ...

[jinfengni <gi...@git.apache.org>]

Github user jinfengni commented on the issue:

    https://github.com/apache/drill/pull/819
  
    2 additional comments.
    
    1. Maybe we need include the length field in MaterializedField.toString() for varchar type if length is set. 
    2. Will a varchar(5) vs varchar(10) be regarded as schema change? The underneath value vector would be same. Not sure if we may see more schema change exception. I tried to come up with some example, but could not find one. It may be worthwhile to think it over. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---