You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/02/25 22:02:41 UTC

[GitHub] [thrift] alex-kormukhin commented on a change in pull request #2534: THRIFT-5519 Java async client loses exceptions in void methods

alex-kormukhin commented on a change in pull request #2534:
URL: https://github.com/apache/thrift/pull/2534#discussion_r815183851



##########
File path: test/VoidMethExceptionsTest.thrift
##########
@@ -0,0 +1,13 @@
+namespace java thrift.test.voidmethexceptions
+
+exception TExampleException {
+  1: required string message;
+}
+
+service TAppService01 {
+  string returnString(1: string msg, 2: bool throwException) throws (1:TExampleException error);
+  void returnVoidThrows(1: string msg, 2: bool throwException) throws (1:TExampleException error);
+  void returnVoidNoThrowsRuntimeException(1: string msg, 2: bool throwException);
+  void returnVoidNoThrowsTApplicationException(1: string msg, 2: bool throwException);
+  oneway void onewayVoidNoThrows(1: string msg, 2: bool throwException);

Review comment:
       Yes, test checks exactly that (no client-side exceptions when server throws, no client-side wait when server hangs). Method name reflects correct signature for such methods.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org