You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by trixpan <gi...@git.apache.org> on 2017/05/15 11:18:44 UTC

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

Github user trixpan commented on the issue:

    https://github.com/apache/nifi/pull/1541
  
    Good news! work has been "completed" and PR squashed and rebased to master. 
    
    Things to notice: 
    
    1. At this stage, test units are marked as ignore as they expect the availability of a live IRC server on localhost for testing. Keen to hear feedback on preferred approach for test units. 
    2. TLS related code is not as clean as the traditional NiFi processor code but seems to work. Given I am not used to use TLS related APIs directly, would appreciate if a more experienced coder could do a sanity check.
    
    Looking forward for your feedback


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---