You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/10/10 21:11:18 UTC

[GitHub] [cordova-docs] brodybits opened a new pull request #1020: [BUG] Clarify sponsorship in the footer

brodybits opened a new pull request #1020: [BUG] Clarify sponsorship in the footer
URL: https://github.com/apache/cordova-docs/pull/1020
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   All
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Existing sponsorship link which shows up on every page in our documentation goes to an ASF "sponsorship" page but it is not so clear that the sponsorship would go to non-coding activities. This is not in line with our needs for project sustainability (apache/cordova#163).
   
   I think we should also direct people to the actual project sustainability issue (apache/cordova#163).
   
   I am including "[BUG]" in the description since I think this is something that needs to be fixed in our documentation.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   - Add a footnote to the Apache "sponsorship" link to *clearly* show the following:
     - that the existing "sponsorship" would go to non-coding activities
     - link to the project sustainability issue (apache/cordova#163)
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   TODO:
   
   - [ ] check that generated documentation renders correctly
   
   ### Checklist
   
   - ~~I've run the tests to see all new and existing tests pass~~
   - ~~I added automated test coverage as appropriate for this change~~
   - ~~Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)~~
   - ~~If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))~~
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org