[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7157: armv7-r/tms570: fix build break

[GitBox <gi...@apache.org>]

acassis commented on code in PR #7157:
URL: https://github.com/apache/incubator-nuttx/pull/7157#discussion_r976657405


##########
arch/arm/src/tms570/Make.defs:
##########
@@ -23,7 +23,7 @@ include armv7-r/Make.defs
 # SAMA5-specific C source files
 
 CHIP_CSRCS  = tms570_boot.c tms570_clockconfig.c tms570_esm.c tms570_gio.c
-CHIP_CSRCS += tms570_irq.c tms570_lowputc.c tms570_serial.c tms570_spi.c

Review Comment:
   Why to remove tms570_spi.c ?



##########
boards/arm/tms570/launchxl-tms57004/scripts/Make.defs:
##########
@@ -25,7 +25,6 @@ include $(TOPDIR)/arch/arm/src/armv7-r/Toolchain.defs
 LDSCRIPT = flash-sram.ld
 ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)$(LDSCRIPT)
 
-ARCHCPUFLAGS = -mcpu=cortex-r4 -mbig-endian

Review Comment:
   I think TMS570 is the only Arch on NuttX that supports Big Endian, it should be a nice platform to verify if there are issues in the system and/or drivers. Is the big-endian passed in other place now or it will assume that ARCH will be little-endian?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org