[GitHub] [incubator-tuweni] atoulme commented on a change in pull request #207: Add Auto-Module-Name attribute to manifest.mf

[GitBox <gi...@apache.org>]

atoulme commented on a change in pull request #207:
URL: https://github.com/apache/incubator-tuweni/pull/207#discussion_r611946958



##########
File path: build.gradle
##########
@@ -355,14 +355,19 @@ allprojects {
   // Packaging and deployment
 
   tasks.withType(Jar) {
+    def moduleName = rootProject.name
     if (rootProject == project) {
       archiveBaseName = project.name
     } else {
       archiveBaseName = rootProject.name + '-' + project.name
+      moduleName += ".${project.name}"
     }
+
     manifest {
       attributes('Implementation-Title': archiveBaseName,
-      'Implementation-Version': project.version)
+      'Implementation-Version': project.version,
+      'Automatic-Module-Name': moduleName.replaceAll("-","\\.")

Review comment:
       Do we have modules that have a `-` in their names? like devp2p-eth?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org