You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "subrat-mishra (via GitHub)" <gi...@apache.org> on 2023/05/29 02:59:16 UTC
[GitHub] [hbase-connectors] subrat-mishra opened a new pull request, #117: HBASE-27883: Use log4j2 instead of log4j for logging.
subrat-mishra opened a new pull request, #117:
URL: https://github.com/apache/hbase-connectors/pull/117
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Apache-HBase commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1663272409
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 28s | master passed |
| +1 :green_heart: | compile | 0m 51s | master passed |
| +1 :green_heart: | javadoc | 0m 53s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 51s | the patch passed |
| +1 :green_heart: | javac | 0m 51s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 21s | root in the patch passed. |
| | | 15m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-connectors/pull/117 |
| Optional Tests | dupname javac javadoc unit xml compile |
| uname | Linux 8fd36361d94d 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | hb_maven |
| Personality | dev-support/jenkins/hbase-personality.sh |
| git revision | master / f8ee8f6 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/2/testReport/ |
| Max. process+thread count | 958 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/2/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] subrat-mishra commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "subrat-mishra (via GitHub)" <gi...@apache.org>.
subrat-mishra commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1667379161
@Reidddddd, could you please take a look at it? I have removed `slf4j-log4j12` from hbase-spark/pom.xml and also the transitive dependencies as well. Is it fine now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Reidddddd commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Reidddddd (via GitHub)" <gi...@apache.org>.
Reidddddd commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1672471722
> That is the groupId for log4j2, check these dependencies for the hbase repository: https://github.com/apache/hbase/blob/master/pom.xml#L1340-L1359
>
> >
not familiar with these parts, thanks for explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Reidddddd merged pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Reidddddd (via GitHub)" <gi...@apache.org>.
Reidddddd merged PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Apache-HBase commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1666582055
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 1m 23s | master passed |
| +1 :green_heart: | compile | 0m 54s | master passed |
| +1 :green_heart: | javadoc | 0m 52s | master passed |
| -0 :warning: | patch | 4m 20s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 48s | the patch passed |
| +1 :green_heart: | compile | 0m 50s | the patch passed |
| +1 :green_heart: | javac | 0m 50s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 13s | root in the patch passed. |
| | | 15m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/4/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-connectors/pull/117 |
| Optional Tests | dupname javac javadoc unit xml compile |
| uname | Linux e0bf72d23183 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | hb_maven |
| Personality | dev-support/jenkins/hbase-personality.sh |
| git revision | master / bfcdf68 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/4/testReport/ |
| Max. process+thread count | 946 (vs. ulimit of 12500) |
| modules | C: kafka/hbase-kafka-proxy spark/hbase-spark spark/hbase-spark-it . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/4/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Apache-HBase commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1566445835
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 35s | master passed |
| +1 :green_heart: | compile | 0m 48s | master passed |
| +1 :green_heart: | javadoc | 0m 48s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 46s | the patch passed |
| +1 :green_heart: | compile | 0m 48s | the patch passed |
| +1 :green_heart: | javac | 0m 48s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 23s | root in the patch passed. |
| | | 16m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-connectors/pull/117 |
| Optional Tests | dupname javac javadoc unit xml compile |
| uname | Linux c159c506c8f9 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 GNU/Linux |
| Build tool | hb_maven |
| Personality | dev-support/jenkins/hbase-personality.sh |
| git revision | master / 2d99724 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/1/testReport/ |
| Max. process+thread count | 957 (vs. ulimit of 12500) |
| modules | C: . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/1/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] subrat-mishra commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "subrat-mishra (via GitHub)" <gi...@apache.org>.
subrat-mishra commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1666578983
re-trigger the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Apache-HBase commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1669822602
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 1m 20s | master passed |
| +1 :green_heart: | compile | 0m 52s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 51s | the patch passed |
| +1 :green_heart: | javac | 0m 51s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 3s | root in the patch passed. |
| | | 15m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/6/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-connectors/pull/117 |
| Optional Tests | dupname javac javadoc unit xml compile |
| uname | Linux 6de5c9c68dab 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 GNU/Linux |
| Build tool | hb_maven |
| Personality | dev-support/jenkins/hbase-personality.sh |
| git revision | master / bfcdf68 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| Test Results | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/6/testReport/ |
| Max. process+thread count | 936 (vs. ulimit of 12500) |
| modules | C: kafka/hbase-kafka-proxy spark/hbase-spark spark/hbase-spark-it . U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-Connectors-PreCommit/job/PR-117/6/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] petersomogyi commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "petersomogyi (via GitHub)" <gi...@apache.org>.
petersomogyi commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1669473953
Should the org.slf4j dependencies be updated? For example slf4j-log4j12 is binding/provider for log4j version 1.2, shouldn't be needed anymore.
SLF4J dependencies in hbase: https://github.com/apache/hbase/blob/master/pom.xml#L1325-L1339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Reidddddd commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Reidddddd (via GitHub)" <gi...@apache.org>.
Reidddddd commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1663321214
emm, hold on
just checked the code base, it seems using `slf4j` not `apache logging`...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Reidddddd commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Reidddddd (via GitHub)" <gi...@apache.org>.
Reidddddd commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1663263767
re-trigger the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] petersomogyi commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "petersomogyi (via GitHub)" <gi...@apache.org>.
petersomogyi commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1669470051
> 1. why replace `log4j` with `org.apache.logging.log4j`
That is the groupId for log4j2, check these dependencies for the hbase repository: https://github.com/apache/hbase/blob/master/pom.xml#L1340-L1359
> 2. and `org.apache.logging.log4j` is still log4j not log4j2? seems not as title describes
org.apache.logging.log4j is with version 2.17.2, so it is log4j2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Reidddddd commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Reidddddd (via GitHub)" <gi...@apache.org>.
Reidddddd commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1667473694
ping @petersomogyi, would you like to give a review as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] Reidddddd commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "Reidddddd (via GitHub)" <gi...@apache.org>.
Reidddddd commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1668828791
@subrat-mishra there are places i don't understand, could you explain them to me
1. why replace `log4j` with `org.apache.logging.log4j`
2. and `org.apache.logging.log4j` is still log4j not log4j2? seems not as title describes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-connectors] subrat-mishra commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.
Posted by "subrat-mishra (via GitHub)" <gi...@apache.org>.
subrat-mishra commented on PR #117:
URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1669786446
> Should the org.slf4j dependencies be updated? For example slf4j-log4j12 is binding/provider for log4j version 1.2, shouldn't be needed anymore. SLF4J dependencies in hbase: https://github.com/apache/hbase/blob/master/pom.xml#L1325-L1339
Thanks @petersomogyi, for pointing that out. I missed removing `slf4j-log4j12` from parent pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org