Re: Hold Noses (was Re: svn commit: r157852 - in apr/apr-iconv/trunk: CHANGES lib/api_version.c lib/iconv_module.c)

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

Thank you Sander!!!

Although yes, I would wish that viewcvs would do so, I understand how
differently deltas are stacked in svn vs cvs.  Obviously, for a given
given pair of mechanisms, each of the functions will perform differently
in terms of speed/bandwidth/storage to one another.  I'll spend my own
CPUs cycles gladly, to have this feature back.

And also obviously, this particular change wasn't hard to backtrack,
but your thorough example of praise/blame below has set me on the right
track to hunt those down.  Bless you :)

p.p.s. I've been frequently to red-bean and own hardcopy, but does 
anyone recommend a well written "svn for cvs users" quick reference, 
both modestly terse and complete?

At 03:24 AM 3/17/2005, Sander Striker wrote:

>Annotation is currently disabled in viewcvs.  It does work, but there
>are some performance issues with it.  There are other ways to get to
>the information though.
>
>Let me show you:
>
> svn praise http://svn.apache.org/repos/asf/apr/apr-iconv/trunk/include/api_version.h
>
> ...
> 157664 jerenkrantz #ifndef API_STRINGIFY
> 157664 jerenkrantz /** Properly quote a value as a string in the C preprocessor */
> 157664 jerenkrantz #define API_STRINGIFY(n) API_STRINGIFY_HELPER(n)
> 157664 jerenkrantz /** Helper macro for API_STRINGIFY */
> 157664 jerenkrantz #define API_STRINGIFY_HELPER(n) #n
> 157664 jerenkrantz #endif
> ...
>
>Ah, rev 157664.  What was that commit?
>
> svn log -r 157664 -v
>
> ------------------------------------------------------------------------
> r157664 | jerenkrantz | 2005-03-16 05:25:48 +0100 (Wed, 16 Mar 2005) | 3 lines
> Changed paths:
>    M /apr/apr-iconv/trunk/CHANGES
>    M /apr/apr-iconv/trunk/include/api_version.h
>    M /apr/apr-iconv/trunk/libapriconv.dsp
>    A /apr/apr-iconv/trunk/libapriconv.rc
>
> Fix libapriconv.rc for Win32 release builds.
> Also sync up CHANGES and bump trunk to 1.1.0-dev.
>
> ------------------------------------------------------------------------
>
>Hmm, let's look at the CHANGES entry before we entirely praise jerenkrantz.
>
> svn diff -r 157663:157664 http://svn.apache.org/repos/asf/apr/apr-iconv/trunk/CHANGES
>
> Index: CHANGES
> ===================================================================
> --- CHANGES    (revision 157663)
> +++ CHANGES    (revision 157664)
> @@ -1,5 +1,13 @@
> -Changes with APR-ICONV 1.0
> +Changes with APR-ICONV 1.1
> +Changes with APR-ICONV 1.0.2
> +
> +  *) Fix libapriconv.rc for Win32 builds [William Rowe, Justin Erenkrantz]
> +
> +Changes with APR-ICONV 1.0.1
> +
> +Changes with APR-ICONV 1.0.0
> +
>    *) Add the possiblity of a DESTDIR prefix to Makefile.in to make it
>       consistent with the behaviour of apr and apr-util. [Graham Leggett]
>
>
>So, this must have had some discussion on list somewhere before the commit.
>The log said it was committed 16th of march, so lets have a look
>
> http://mail-archives.apache.org/mod_mbox/apr-dev/
>
>[...stops looking for the mystery patch and starts packing...]