You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "mridulm (via GitHub)" <gi...@apache.org> on 2024/04/05 00:39:56 UTC
[PR] [CELEBORN-1372] Update ControlMessages to handle ApplicationMeta and ApplicationMetaRequest [celeborn]
mridulm opened a new pull request, #2447:
URL: https://github.com/apache/celeborn/pull/2447
### What changes were proposed in this pull request?
With authentication enabled, rpc requests from executors to driver and vice versa fail when trying to send/receive `ApplicationMeta` and `ApplicationMetaRequest`.
### Why are the changes needed?
Executor is unable to communicate with the driver with auth enabled.
### Does this PR introduce _any_ user-facing change?
No, bug fix for feature introduced in 0.5
### How was this patch tested?
Tested with spark 3.1 against a patched version of Celeborn (pre-reqs: #2445, #2446)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1372] Update ControlMessages to handle ApplicationMeta and ApplicationMetaRequest [celeborn]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #2447:
URL: https://github.com/apache/celeborn/pull/2447#issuecomment-2038560785
Thanks for the quick review @pan3793 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1372] Update ControlMessages to handle ApplicationMeta and ApplicationMetaRequest [celeborn]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2447:
URL: https://github.com/apache/celeborn/pull/2447#issuecomment-2038551498
## [Codecov](https://app.codecov.io/gh/apache/celeborn/pull/2447?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `6 lines` in your changes are missing coverage. Please review.
> Project coverage is 39.21%. Comparing base [(`6153ba4`)](https://app.codecov.io/gh/apache/celeborn/commit/6153ba4c627de4bdeedcb4f1e4ae45f18ad2965b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`51b008a`)](https://app.codecov.io/gh/apache/celeborn/pull/2447?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on main.
| [Files](https://app.codecov.io/gh/apache/celeborn/pull/2447?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...born/common/protocol/message/ControlMessages.scala](https://app.codecov.io/gh/apache/celeborn/pull/2447?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fceleborn%2Fcommon%2Fprotocol%2Fmessage%2FControlMessages.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL3Byb3RvY29sL21lc3NhZ2UvQ29udHJvbE1lc3NhZ2VzLnNjYWxh) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/celeborn/pull/2447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2447 +/- ##
==========================================
- Coverage 39.24% 39.21% -0.02%
==========================================
Files 217 217
Lines 13432 13438 +6
Branches 1173 1175 +2
==========================================
- Hits 5270 5269 -1
- Misses 7863 7871 +8
+ Partials 299 298 -1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celeborn/pull/2447?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1372] Update ControlMessages to handle ApplicationMeta and ApplicationMetaRequest [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #2447: [CELEBORN-1372] Update ControlMessages to handle ApplicationMeta and ApplicationMetaRequest
URL: https://github.com/apache/celeborn/pull/2447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1372] Update ControlMessages to handle ApplicationMeta and ApplicationMetaRequest [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #2447:
URL: https://github.com/apache/celeborn/pull/2447#issuecomment-2038552948
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org