You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ad...@apache.org on 2017/12/12 14:13:29 UTC

[08/11] james-project git commit: JAMES-2249 jmap cucumber steps: remove useless throws

JAMES-2249 jmap cucumber steps: remove useless throws


Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/7b8630ef
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/7b8630ef
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/7b8630ef

Branch: refs/heads/master
Commit: 7b8630ef1844f454dd82b9a1ceffa7837e0ba2f0
Parents: 40c0043
Author: Luc DUZAN <ld...@linagora.com>
Authored: Mon Dec 11 15:38:37 2017 +0100
Committer: Antoine Duprat <ad...@linagora.com>
Committed: Tue Dec 12 15:12:36 2017 +0100

----------------------------------------------------------------------
 .../integration/cucumber/DownloadStepdefs.java  | 12 +++++-----
 .../cucumber/GetMailboxesMethodStepdefs.java    |  4 ++--
 .../cucumber/SetMailboxesMethodStepdefs.java    | 14 ++++++------
 .../cucumber/SetMessagesMethodStepdefs.java     | 24 ++++++++++----------
 .../cucumber/StringListToFlagsTest.java         | 16 ++++++-------
 .../integration/cucumber/UploadStepdefs.java    | 16 ++++++-------
 .../integration/cucumber/UserStepdefs.java      |  6 ++---
 7 files changed, 46 insertions(+), 46 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
index 6d852f2..b475e60 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/DownloadStepdefs.java
@@ -247,7 +247,7 @@ public class DownloadStepdefs {
     }
 
     @When("^\"([^\"]*)\" downloads \"(?:[^\"]*)\" with a valid authentication token but a bad blobId$")
-    public void downloadsWithValidToken(String username) throws Throwable {
+    public void downloadsWithValidToken(String username) {
         userStepdefs.execWithUser(username, () -> {
             URIBuilder uriBuilder = mainStepdefs.baseUri().setPath("/download/badblobId");
             response = Request.Get(uriBuilder.build())
@@ -368,7 +368,7 @@ public class DownloadStepdefs {
     }
 
     @Then("^\"([^\"]*)\" be authorized$")
-    public void httpStatusDifferentFromUnauthorized(String username) throws Throwable {
+    public void httpStatusDifferentFromUnauthorized(String username) {
         userStepdefs.execWithUser(username, this::httpStatusDifferentFromUnauthorized);
     }
 
@@ -378,7 +378,7 @@ public class DownloadStepdefs {
     }
 
     @Then("^\"([^\"]*)\" should not be authorized$")
-    public void httpUnauthorizedStatus(String username) throws Throwable {
+    public void httpUnauthorizedStatus(String username) {
         userStepdefs.execWithUser(username, this::httpUnauthorizedStatus);
     }
 
@@ -388,7 +388,7 @@ public class DownloadStepdefs {
     }
 
     @Then("^\"([^\"]*)\" should receive a bad request response$")
-    public void httpBadRequestStatus(String username) throws Throwable {
+    public void httpBadRequestStatus(String username) {
         userStepdefs.execWithUser(username, this::httpBadRequestStatus);
     }
 
@@ -404,7 +404,7 @@ public class DownloadStepdefs {
     }
 
     @Then("^\"([^\"]*)\" should receive a not found response$")
-    public void httpNotFoundStatus(String username) throws Throwable {
+    public void httpNotFoundStatus(String username) {
         userStepdefs.execWithUser(username, this::httpNotFoundStatus);
     }
 
@@ -416,7 +416,7 @@ public class DownloadStepdefs {
     }
 
     @Then("^\"([^\"]*)\" should receive an attachment access token$")
-    public void accessTokenResponse(String username) throws Throwable {
+    public void accessTokenResponse(String username) {
         userStepdefs.execWithUser(username, this::accessTokenResponse);
     }
 

http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/GetMailboxesMethodStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/GetMailboxesMethodStepdefs.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/GetMailboxesMethodStepdefs.java
index 93cb8ca..b293819 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/GetMailboxesMethodStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/GetMailboxesMethodStepdefs.java
@@ -53,7 +53,7 @@ public class GetMailboxesMethodStepdefs {
     }
 
     @When("^\"([^\"]*)\" lists mailboxes$")
-    public void getMailboxes(String user) throws Throwable {
+    public void getMailboxes(String user) {
         userStepdefs.execWithUser(user, 
                 () -> httpClient.post("[[\"getMailboxes\", {}, \"#0\"]]"));
     }
@@ -65,7 +65,7 @@ public class GetMailboxesMethodStepdefs {
     }
 
     @Then("^the list should contain (\\d+) (?:mailbox|mailboxes)$")
-    public void assertNumberOfMailboxes(int numberOfMailboxes) throws Exception {
+    public void assertNumberOfMailboxes(int numberOfMailboxes) {
         assertThat(httpClient.jsonPath.<List<String>>read(ARGUMENTS + ".list")).hasSize(numberOfMailboxes);
     }
 

http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMailboxesMethodStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMailboxesMethodStepdefs.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMailboxesMethodStepdefs.java
index 42b37c5..3be7bfb 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMailboxesMethodStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMailboxesMethodStepdefs.java
@@ -69,7 +69,7 @@ public class SetMailboxesMethodStepdefs {
     }
 
     @Given("^mailbox \"([^\"]*)\" with (\\d+) messages$")
-    public void mailboxWithMessages(String mailboxName, int messageCount) throws Throwable {
+    public void mailboxWithMessages(String mailboxName, int messageCount) {
         mainStepdefs.mailboxProbe.createMailbox("#private", userStepdefs.getConnectedUser(), mailboxName);
         MailboxPath mailboxPath = MailboxPath.forUser(userStepdefs.getConnectedUser(), mailboxName);
         IntStream
@@ -86,7 +86,7 @@ public class SetMailboxesMethodStepdefs {
     }
 
     @Given("^\"([^\"]*)\" has a mailbox \"([^\"]*)\"$")
-    public void createMailbox(String username, String mailbox) throws Throwable {
+    public void createMailbox(String username, String mailbox) {
         mainStepdefs.mailboxProbe.createMailbox(MailboxConstants.USER_NAMESPACE, username, mailbox);
     }
 
@@ -269,7 +269,7 @@ public class SetMailboxesMethodStepdefs {
     }
 
     @Then("^mailbox \"([^\"]*)\" contains (\\d+) messages$")
-    public void mailboxContainsMessages(String mailboxName, int messageCount) throws Throwable {
+    public void mailboxContainsMessages(String mailboxName, int messageCount) {
         Duration slowPacedPollInterval = Duration.FIVE_HUNDRED_MILLISECONDS;
         String username = userStepdefs.getConnectedUser();
         String mailboxId = mainStepdefs.getMailboxId(username, mailboxName).serialize();
@@ -288,7 +288,7 @@ public class SetMailboxesMethodStepdefs {
     }
 
     @Then("^\"([^\"]*)\" receives not updated on mailbox \"([^\"]*)\" with kind \"([^\"]*)\" and message \"([^\"]*)\"$")
-    public void assertNotUpdatedWithGivenProperties(String userName, String mailboxName, String type, String message) throws Exception {
+    public void assertNotUpdatedWithGivenProperties(String userName, String mailboxName, String type, String message) {
         String mailboxId = mainStepdefs.getMailboxId(userName, mailboxName).serialize();
         assertThat(httpClient.response.getStatusLine().getStatusCode()).isEqualTo(200);
         assertThat(httpClient.jsonPath.<String>read(NAME)).isEqualTo("mailboxesSet");
@@ -301,14 +301,14 @@ public class SetMailboxesMethodStepdefs {
     }
 
     @Then("^mailbox \"([^\"]*)\" owned by \"([^\"]*)\" is not updated")
-    public void assertNotUpdated(String mailboxName, String owner) throws Exception {
+    public void assertNotUpdated(String mailboxName, String owner) {
         String mailboxId = mainStepdefs.getMailboxId(owner, mailboxName).serialize();
         assertThat(httpClient.jsonPath.<Map<String, String>>read("[0][1].notUpdated"))
             .containsOnlyKeys(mailboxId);
     }
 
     @Then("^mailbox \"([^\"]*)\" owned by \"([^\"]*)\" is not destroyed$")
-    public void assertNotDestroyed(String mailboxName, String owner) throws Exception {
+    public void assertNotDestroyed(String mailboxName, String owner) {
         String mailboxId = mainStepdefs.getMailboxId(owner, mailboxName).serialize();
         assertThat(httpClient.jsonPath.<Map<String, String>>read("[0][1].notDestroyed"))
             .containsOnlyKeys(mailboxId);
@@ -316,7 +316,7 @@ public class SetMailboxesMethodStepdefs {
 
 
     @Then("^mailbox with creationId \"([^\"]*)\" is not created")
-    public void assertNotCreated(String creationId) throws Exception {
+    public void assertNotCreated(String creationId) {
         assertThat(httpClient.jsonPath.<Map<String, String>>read("[0][1].notCreated"))
             .containsOnlyKeys(creationId);
     }

http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMessagesMethodStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMessagesMethodStepdefs.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMessagesMethodStepdefs.java
index e2d276c..c539a9d 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMessagesMethodStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/SetMessagesMethodStepdefs.java
@@ -60,7 +60,7 @@ public class SetMessagesMethodStepdefs {
     }
 
     @When("^\"([^\"]*)\" moves \"([^\"]*)\" to user mailbox \"([^\"]*)\"$")
-    public void moveMessageToMailboxWithUser(String username, String message, String mailbox) throws Throwable {
+    public void moveMessageToMailboxWithUser(String username, String message, String mailbox) {
         userStepdefs.execWithUser(username, () -> moveMessageToMailbox(message, mailbox));
     }
 
@@ -105,7 +105,7 @@ public class SetMessagesMethodStepdefs {
     }
 
     @When("^\"([^\"]*)\" copies \"([^\"]*)\" from mailbox \"([^\"]*)\" to mailbox \"([^\"]*)\"$")
-    public void copyMessageToMailbox(String username, String message, String sourceMailbox, String destinationMailbox) throws Throwable {
+    public void copyMessageToMailbox(String username, String message, String sourceMailbox, String destinationMailbox) {
         userStepdefs.execWithUser(username, () -> copyMessageToMailbox(message, sourceMailbox, destinationMailbox));
     }
 
@@ -131,7 +131,7 @@ public class SetMessagesMethodStepdefs {
     }
 
     @When("^\"([^\"]*)\" copies \"([^\"]*)\" from mailbox \"([^\"]*)\" of user \"([^\"]*)\" to mailbox \"([^\"]*)\" of user \"([^\"]*)\"$")
-    public void copyMessageToMailbox(String username, String message, String sourceMailbox, String sourceUser, String destinationMailbox, String destinationUser) throws Throwable {
+    public void copyMessageToMailbox(String username, String message, String sourceMailbox, String sourceUser, String destinationMailbox, String destinationUser) {
         userStepdefs.execWithUser(username, () -> copyMessageToMailbox(message, sourceMailbox, sourceUser, destinationMailbox, destinationUser));
     }
 
@@ -155,7 +155,7 @@ public class SetMessagesMethodStepdefs {
     }
 
     @Given("^\"([^\"]*)\" moves \"([^\"]*)\" to mailbox \"([^\"]*)\" of user \"([^\"]*)\"$")
-    public void moveMessageToMailbox(String username, String message, String destinationMailbox, String destinationUser) throws Throwable {
+    public void moveMessageToMailbox(String username, String message, String destinationMailbox, String destinationUser) {
         userStepdefs.execWithUser(username, () -> moveMessageToMailbox(message, destinationMailbox, destinationUser));
     }
 
@@ -178,12 +178,12 @@ public class SetMessagesMethodStepdefs {
     }
 
     @When("^\"([^\"]*)\" sets flags \"([^\"]*)\" on message \"([^\"]*)\"$")
-    public void setFlags(String username, List<String> keywords, String message) throws Throwable {
+    public void setFlags(String username, List<String> keywords, String message) {
         userStepdefs.execWithUser(username, () -> setFlags(keywords, message));
     }
 
     @When("^\"([^\"]*)\" marks the message \"([^\"]*)\" as flagged$")
-    public void flag(String username, String message) throws Throwable {
+    public void flag(String username, String message) {
         userStepdefs.execWithUser(username, () -> {
             MessageId messageId = messageIdStepdefs.getMessageId(message);
 
@@ -203,7 +203,7 @@ public class SetMessagesMethodStepdefs {
     }
 
     @When("^\"([^\"]*)\" destroys message \"([^\"]*)\"$")
-    public void destroyMessage(String username, String message) throws Throwable {
+    public void destroyMessage(String username, String message) {
         MessageId messageId = messageIdStepdefs.getMessageId(message);
         userStepdefs.execWithUser(username, () -> {
             httpClient.post("[" +
@@ -220,7 +220,7 @@ public class SetMessagesMethodStepdefs {
     }
 
     @Given("^\"([^\"]*)\" tries to create a draft message \"([^\"]*)\" in mailbox \"([^\"]*)\"$")
-    public void createDraft(String username, String message, String mailboxName) throws Throwable {
+    public void createDraft(String username, String message, String mailboxName) {
         userStepdefs.execWithUser(username, () -> {
             String mailboxId = mainStepdefs.getMailboxId(username, mailboxName).serialize();
             httpClient.post("[" +
@@ -284,27 +284,27 @@ public class SetMessagesMethodStepdefs {
     }
 
     @Then("^message \"([^\"]*)\" is not updated$")
-    public void assertNotUpdate(String messageName) throws Exception {
+    public void assertNotUpdate(String messageName) {
         MessageId id = messageIdStepdefs.getMessageId(messageName);
         assertThat(httpClient.jsonPath.<Map<String, String>>read("[0][1].notUpdated"))
             .containsOnlyKeys(id.serialize());
     }
 
     @Then("^message \"([^\"]*)\" is updated$")
-    public void assertUpdated(String messageName) throws Exception {
+    public void assertUpdated(String messageName) {
         MessageId id = messageIdStepdefs.getMessageId(messageName);
         assertThat(httpClient.jsonPath.<List<String>>read("[0][1].updated"))
             .containsOnly(id.serialize());
     }
 
     @Then("^message \"([^\"]*)\" is not created$")
-    public void assertNotCreated(String messageName) throws Exception {
+    public void assertNotCreated(String messageName) {
         assertThat(httpClient.jsonPath.<Map<String, String>>read("[0][1].notCreated"))
             .containsOnlyKeys(messageName);
     }
 
     @Then("^message \"([^\"]*)\" is created$")
-    public void assertCreated(String messageName) throws Exception {
+    public void assertCreated(String messageName) {
         assertThat(httpClient.jsonPath.<Map<String, String>>read("[0][1].created"))
             .containsOnlyKeys(messageName);
     }

http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/StringListToFlagsTest.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/StringListToFlagsTest.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/StringListToFlagsTest.java
index 9ae5aa0..0f7ee58 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/StringListToFlagsTest.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/StringListToFlagsTest.java
@@ -30,49 +30,49 @@ import org.testcontainers.shaded.com.google.common.collect.ImmutableList;
 
 public class StringListToFlagsTest {
     @Test
-    public void fromFlagListShouldConvertAnwseredFlag() throws Exception {
+    public void fromFlagListShouldConvertAnwseredFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of(Keyword.ANSWERED.getFlagName())))
             .isEqualTo(new Flags(Flag.ANSWERED));
     }
 
     @Test
-    public void fromFlagListShouldConvertSeenFlag() throws Exception {
+    public void fromFlagListShouldConvertSeenFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of(Keyword.SEEN.getFlagName())))
             .isEqualTo(new Flags(Flag.SEEN));
     }
 
     @Test
-    public void fromFlagListShouldConvertDraftFlag() throws Exception {
+    public void fromFlagListShouldConvertDraftFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of(Keyword.DRAFT.getFlagName())))
             .isEqualTo(new Flags(Flag.DRAFT));
     }
 
     @Test
-    public void fromFlagListShouldConvertRecentFlag() throws Exception {
+    public void fromFlagListShouldConvertRecentFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of(Keyword.RECENT.getFlagName())))
             .isEqualTo(new Flags(Flag.RECENT));
     }
 
     @Test
-    public void fromFlagListShouldConvertDeletedFlag() throws Exception {
+    public void fromFlagListShouldConvertDeletedFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of(Keyword.DELETED.getFlagName())))
             .isEqualTo(new Flags(Flag.DELETED));
     }
 
     @Test
-    public void fromFlagListShouldConvertFlaggedFlag() throws Exception {
+    public void fromFlagListShouldConvertFlaggedFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of(Keyword.FLAGGED.getFlagName())))
             .isEqualTo(new Flags(Flag.FLAGGED));
     }
 
     @Test
-    public void fromFlagListShouldConvertValidJMAPFlag() throws Exception {
+    public void fromFlagListShouldConvertValidJMAPFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of("$Any")))
             .isEqualTo(new Flags("$Any"));
     }
 
     @Test
-    public void fromFlagListShouldConvertInvalidJMAPFlag() throws Exception {
+    public void fromFlagListShouldConvertInvalidJMAPFlag() {
         assertThat(StringListToFlags.fromFlagList(ImmutableList.of("op§")))
             .isEqualTo(new Flags("op§"));
     }

http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UploadStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UploadStepdefs.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UploadStepdefs.java
index fea5838..0422ba0 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UploadStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UploadStepdefs.java
@@ -72,7 +72,7 @@ public class UploadStepdefs {
     }
 
     @Given("^\"([^\"]*)\" is starting uploading a content$")
-    public void userStartUploadContent(String username) throws Throwable {
+    public void userStartUploadContent(String username) {
         AccessToken accessToken = userStepdefs.authenticate(username);
 
         CountDownLatch startSignal = new CountDownLatch(2);
@@ -155,32 +155,32 @@ public class UploadStepdefs {
     }
 
     @Then("^the user disconnect$")
-    public void stopUpload() throws Throwable {
+    public void stopUpload() {
         async.cancel(true);
     }
 
     @Then("^the user should receive an authorized response$")
-    public void httpAuthorizedStatus() throws Exception {
+    public void httpAuthorizedStatus() {
         assertThat(response.getStatusLine().getStatusCode()).isEqualTo(200);
     }
 
     @Then("^the user should receive a created response$")
-    public void httpCreatedStatus() throws Exception {
+    public void httpCreatedStatus() {
         assertThat(response.getStatusLine().getStatusCode()).isEqualTo(201);
     }
 
     @Then("^the user should receive bad request response$")
-    public void httpBadRequestStatus() throws Throwable {
+    public void httpBadRequestStatus() {
         assertThat(response.getStatusLine().getStatusCode()).isEqualTo(400);
     }
 
     @Then("^the user should receive a not authorized response$")
-    public void httpUnauthorizedStatus() throws Exception {
+    public void httpUnauthorizedStatus() {
         assertThat(response.getStatusLine().getStatusCode()).isEqualTo(401);
     }
 
     @Then("^the user should receive a request entity too large response$")
-    public void httpRequestEntityTooBigStatus() throws Exception {
+    public void httpRequestEntityTooBigStatus() {
         assertThat(response.getStatusLine().getStatusCode()).isEqualTo(413);
     }
 
@@ -213,7 +213,7 @@ public class UploadStepdefs {
     }
 
     @Then("^the request should be marked as canceled$")
-    public void requestHasBeenCanceled() throws Exception {
+    public void requestHasBeenCanceled() {
         assertThat(isCanceled).isTrue();
     }
 }

http://git-wip-us.apache.org/repos/asf/james-project/blob/7b8630ef/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UserStepdefs.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UserStepdefs.java b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UserStepdefs.java
index 1c23178..6414473 100644
--- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UserStepdefs.java
+++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/java/org/apache/james/jmap/methods/integration/cucumber/UserStepdefs.java
@@ -59,7 +59,7 @@ public class UserStepdefs {
         this.lastConnectedUser = Optional.empty();
     }
 
-    public void execWithUser(String user, ThrowingRunnable sideEffect) throws Exception {
+    public void execWithUser(String user, ThrowingRunnable sideEffect) {
         Optional<String> previousConnectedUser = lastConnectedUser;
         connectUser(user);
         try {
@@ -88,7 +88,7 @@ public class UserStepdefs {
     }
 
     @Given("^some users (.*)$")
-    public void createUsers(List<String> users) throws Throwable {
+    public void createUsers(List<String> users) {
         users.stream()
             .map(this::unquote)
             .forEach(Throwing.consumer(this::createUser));
@@ -112,7 +112,7 @@ public class UserStepdefs {
     }
 
     @Given("^\"([^\"]*)\" is connected$")
-    public void connectUser(String username) throws Exception {
+    public void connectUser(String username) {
         AccessToken accessToken = authenticate(username);
         tokenByUser.put(username, accessToken);
         lastConnectedUser = Optional.of(username);


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org