You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by li...@apache.org on 2026/08/28 06:43:02 UTC

(iceberg-rust) branch main updated: refactor: change from serialising a u64 to i64 (#3065)

This is an automated email from the ASF dual-hosted git repository.

blackmwk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git


The following commit(s) were added to refs/heads/main by this push:
     new 76572cf58 refactor: change from serialising a u64 to i64 (#3065)
76572cf58 is described below

commit 76572cf58ef255201b95816e5f8178a7b351b8d8
Author: Joseph Lenton <Jo...@users.noreply.github.com>
AuthorDate: Fri Aug 28 07:42:57 2026 +0100

    refactor: change from serialising a u64 to i64 (#3065)
---
 crates/iceberg/src/spec/manifest_list/_serde.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crates/iceberg/src/spec/manifest_list/_serde.rs b/crates/iceberg/src/spec/manifest_list/_serde.rs
index 1756d5bbf..2a10c39ea 100644
--- a/crates/iceberg/src/spec/manifest_list/_serde.rs
+++ b/crates/iceberg/src/spec/manifest_list/_serde.rs
@@ -193,7 +193,7 @@ pub(super) struct ManifestFileV3 {
     pub deleted_rows_count: i64,
     pub partitions: Option<Vec<FieldSummary>>,
     pub key_metadata: Option<ByteBuf>,
-    pub first_row_id: Option<u64>,
+    pub first_row_id: Option<i64>,
 }
 
 impl ManifestFileV3 {
@@ -215,7 +215,7 @@ impl ManifestFileV3 {
             deleted_rows_count: Some(self.deleted_rows_count.try_into()?),
             partitions: self.partitions,
             key_metadata: self.key_metadata.map(|b| b.into_vec()),
-            first_row_id: self.first_row_id,
+            first_row_id: self.first_row_id.map(|n| n.try_into()).transpose()?,
         };
 
         Ok(manifest_file)
@@ -372,7 +372,7 @@ impl TryFrom<ManifestFile> for ManifestFileV3 {
                 .try_into()?,
             partitions: value.partitions,
             key_metadata,
-            first_row_id: value.first_row_id,
+            first_row_id: value.first_row_id.map(|n| n.try_into()).transpose()?,
         })
     }
 }