You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2014/09/02 17:21:44 UTC

[GitHub] couchdb-fauxton pull request: New Documents Pagination

GitHub user garrensmith opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/53

    New Documents Pagination

    New pagination design for the database page. Screenshot:
    ![](https://www.dropbox.com/s/bdhd2c0pru0delo/Screenshot%202014-09-02%2017.19.45.png?dl=1)
    
    This patch also includes a fix for the all database page where the last item in the list is covered by the pagination.
    
    Initial work by
    deathbearbrown@gmail.com and Jenn Schiffer jenn@pancaketheorem.com.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/garrensmith/couchdb-fauxton new-documents-pagination

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 0d5f0e7dcc2bc002dfd99f3b95bcc5119a9d6635
Author: Garren Smith <ga...@gmail.com>
Date:   2014-09-02T15:04:04Z

    New Documents Pagination
    
    Initial work by
    deathbearbrown@gmail.com and Jenn Schiffer jenn@pancaketheorem.com.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54172320
  
    Ah, that's not related to this PR - this bug was before. So I have two more issues to fill.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#discussion_r16998320
  
    --- Diff: app/addons/documents/templates/all_docs_number.html ---
    @@ -12,9 +12,10 @@
     the License.
     -->
     <% if (totalRows === "unknown" || totalRows === 0){ %>
    -Showing 0 documents. <a href="#/database/<%=database%>/new"> Create your first document.</a>
    +<p>Showing 0 documents.</p>
     <% } else { %>
    -Showing <%=pageStart%> - <%= pageEnd %>
    +
    +<p>Showing <%=pageStart%> - <%= pageEnd %></p>
    --- End diff --
    
    friendly xss reminder (please use `<-`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/53


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54304852
  
    Merged in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54295993
  
    @garrensmith cool! look forward for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54278577
  
    >> As about design bits, this change completely kills document list scrollbar - there is no way to use it, especially for large list.
    >
    > What do you mean by document list scrollbar? Could you post a screenshot that might explain it a little more.
    
    ![](http://i.imgur.com/XxjlE2W.png)
    
    I have to click almost 4 times on scrollbar to get bar visible to be able move him around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54298575
  
    2314 looks fixed. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54172560
  
    And more one bit: prev/next arrows styling is different from pagination on database list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54172462
  
    Great testing thanks. I can look at that issue tomorrow.
    
    On Tuesday, September 2, 2014, Alexander Shorin <no...@github.com>
    wrote:
    
    > Ah, that's not related to this PR - this bug was before. So I have two
    > more issues to fill.
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54172320>.
    >


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#discussion_r17041129
  
    --- Diff: app/addons/documents/templates/all_docs_number.html ---
    @@ -12,9 +12,10 @@
     the License.
     -->
     <% if (totalRows === "unknown" || totalRows === 0){ %>
    -Showing 0 documents. <a href="#/database/<%=database%>/new"> Create your first document.</a>
    +<p>Showing 0 documents.</p>
     <% } else { %>
    -Showing <%=pageStart%> - <%= pageEnd %>
    +
    +<p>Showing <%=pageStart%> - <%= pageEnd %></p>
    --- End diff --
    
    Thanks good spot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54277749
  
    >As about design bits, this change completely kills document list scrollbar - there is no way to use it, especially for large list.
    
    What do you mean by document list scrollbar? Could you post a screenshot that might explain it a little more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54295872
  
    I've made some bug fixes and improvements. @kxepal and @robertkowalski could you take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54170583
  
    Hm...open database with single document. Change page size: now you see the two docs. Repeat for moar documents!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by garrensmith <gi...@git.apache.org>.

Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54295811
  
    @kxepal, the scrollbar issue will be fixed in one of my next PR's when I add the new query options.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: New Documents Pagination

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/53#issuecomment-54172460
  
    As about design bits, this change completely kills document list scrollbar - there is no way to use it, especially for large list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---