You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-dev@hadoop.apache.org by Kihwal Lee <ki...@verizonmedia.com.INVALID> on 2021/05/24 21:45:37 UTC
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
+1 for the 100 char limit.
But I would have liked 132 columns more. :)
Kihwal
On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi folks!
>
> The consensus seems pretty strongly in favor of increasing the line length
> limit. Do folks still want to see a formal VOTE thread?
>
>
> > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>