You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/06/03 12:57:51 UTC
Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT
test_non_contiguous_vlan.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Bugs: CLOUDSTACK-6776
https://issues.apache.org/jira/browse/CLOUDSTACK-6776
Repository: cloudstack-git
Description
-------
The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
Diffs
-----
test/integration/smoke/test_non_contigiousvlan.py 90235ec
Diff: https://reviews.apache.org/r/22197/diff/
Testing
-------
Yes.
Log:
Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 15.328s
OK
~
~
Thanks,
Ashutosh Kelkar
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_non_contigiousvlan.py, line 47
> > <https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line47>
> >
> > As well, can we run these changes once and see no issues if its possible?
Yes I did run it again after the changes.
> On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_non_contigiousvlan.py, line 45
> > <https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line45>
> >
> > It seems we are not reading test data. Can we check that?
It is not required here. As only test data the test case was earlier reading was vlan ids. And now we have removed that data and getting the free vlan ids through code from the setup.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44616
-----------------------------------------------------------
On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44616
-----------------------------------------------------------
test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79036>
It seems we are not reading test data. Can we check that?
test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79037>
As well, can we run these changes once and see no issues if its possible?
- Santhosh Edukulla
On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44800
-----------------------------------------------------------
Commit 81bf37f33853d95e7c4137d57a60e719963913c4 in cloudstack's branch refs/heads/4.4-forward from Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=81bf37f ]
CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
- ASF Subversion and Git Services
On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44801
-----------------------------------------------------------
Commit 96272f4cde4e1012da820264ff91c43a9ec255c4 in cloudstack's branch refs/heads/master from Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=96272f4 ]
CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
Conflicts:
test/integration/smoke/test_non_contigiousvlan.py
- ASF Subversion and Git Services
On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44702
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/
-----------------------------------------------------------
(Updated June 3, 2014, 11:45 a.m.)
Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-6776
https://issues.apache.org/jira/browse/CLOUDSTACK-6776
Repository: cloudstack-git
Description
-------
The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
Diffs (updated)
-----
test/integration/smoke/test_non_contigiousvlan.py 90235ec
Diff: https://reviews.apache.org/r/22197/diff/
Testing
-------
Yes.
Log:
Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 15.328s
OK
~
~
Thanks,
Ashutosh Kelkar
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On June 3, 2014, 11:22 a.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_non_contigiousvlan.py, line 29
> > <https://reviews.apache.org/r/22197/diff/1/?file=602789#file602789line29>
> >
> > Is it ok to move to test data?
Removed services dictionary as it is no longer used
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44612
-----------------------------------------------------------
On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from
BVT test_non_contiguous_vlan.py
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22197/#review44612
-----------------------------------------------------------
test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79031>
Is it ok to move to test data?
test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79034>
We assigned self.vlan to Services()... and again list unpacking is using self.vlan, so self.vlan was overwritten, please check.
test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79032>
It should be "is None" comparison.
test/integration/smoke/test_non_contigiousvlan.py
<https://reviews.apache.org/r/22197/#comment79033>
Do we want to fail in setup or raise exception? As such its a setup which is having issue not the test case..
- Santhosh Edukulla
On June 3, 2014, 10:57 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22197/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 10:57 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6776
> https://issues.apache.org/jira/browse/CLOUDSTACK-6776
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py 90235ec
>
> Diff: https://reviews.apache.org/r/22197/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Log:
> Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 15.328s
>
> OK
> ~
> ~
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>