You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/11/13 07:26:47 UTC
[GitHub] [druid] zhangyue19921010 opened a new pull request #10581: Web console: Double confirm before permanently delete unused segments
zhangyue19921010 opened a new pull request #10581:
URL: https://github.com/apache/druid/pull/10581
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
Delete unused segments is a permanent and dangerous action. This PR adds two warningChecks before users press the confirm button `Permanently delete unused segments`
#### Before
<img width="1680" alt="屏幕快照 2020-11-13 下午3 12 46" src="https://user-images.githubusercontent.com/69956021/99040628-6c8e1280-25c4-11eb-9022-777b5012ff0c.png">
#### After
<img width="1676" alt="屏幕快照 2020-11-13 下午3 12 19" src="https://user-images.githubusercontent.com/69956021/99040629-6e57d600-25c4-11eb-8356-731251b51eae.png">
<img width="1680" alt="屏幕快照 2020-11-13 下午3 12 26" src="https://user-images.githubusercontent.com/69956021/99040634-6f890300-25c4-11eb-9ec3-43073ad66c1c.png">
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* `web-console/src/views/datasource-view/datasource-view.tsx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10581:
URL: https://github.com/apache/druid/pull/10581#issuecomment-730039743
@capistrant Sorry to bother you , I have deployed this PR in our PRD druid cluster and it works fine. What should I do now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #10581:
URL: https://github.com/apache/druid/pull/10581#issuecomment-730039743
@capistrant Sorry to bother you , I have deployed this PR in our PRD druid cluster recently and it works fine. What should I do now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10581:
URL: https://github.com/apache/druid/pull/10581#issuecomment-730799510
@capistrant Thanks for your review and merge ! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 commented on pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #10581:
URL: https://github.com/apache/druid/pull/10581#issuecomment-727992667
@capistrant @nishantmonu51 Thanks for your review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant merged pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
capistrant merged pull request #10581:
URL: https://github.com/apache/druid/pull/10581
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] capistrant commented on pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
capistrant commented on pull request #10581:
URL: https://github.com/apache/druid/pull/10581#issuecomment-730108940
> @capistrant Hi capistrant! Sorry to bother you , I have deployed this PR in our PRD druid cluster recently and it works fine. What should I do next?
I'll merge it by the end of the week. I usually let approved PRs sit for a few days to give others in the community time to take a look and add any thoughts they may have
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10581: Web console: Double confirm before permanently delete unused segments
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 edited a comment on pull request #10581:
URL: https://github.com/apache/druid/pull/10581#issuecomment-730039743
@capistrant Hi capistrant! Sorry to bother you , I have deployed this PR in our PRD druid cluster recently and it works fine. What should I do next?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org