You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sandesha-dev@ws.apache.org by Andrew K Gatford <GA...@uk.ibm.com> on 2006/06/29 10:09:27 UTC
Sandesha2: Unused methods in the Bean managers
Whilst trying to understand the Bean Managers, I've found that there are
several methods that are not actually called.
InvokerBeanMgr.java
findUnique
SenderBeanMgr.java
findUnique
retrieveFromMessageRefKey
NextMsgBeanMgr
delete
I'm guessing that the delete method will be used at some point and there
are places in the code where it is commented out, but will the others?
Should these methods be removed so people can avoid implementing methods
that will never be used ?
Also, it would be nice to see some java doc for the methods to describe
what is expected of the Bean manager implementations.
Thanks
Andrew Gatford
Hursley MP211
Telephone :
Internal (7) 245743
External 01962 815743
Internet : gatfora@uk.ibm.com
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
Re: Sandesha2: Unused methods in the Bean managers
Posted by Chamikara Jayalath <ch...@gmail.com>.
Hi Andrew,
I guess its better to keep the delete and findUnique methods to provide a
consistend API.
But 'retrieveFromMessageRefKey' method is not used any more. I'll deprecate
this.
Chamikara
On 6/29/06, Andrew K Gatford <GA...@uk.ibm.com> wrote:
>
>
> Whilst trying to understand the Bean Managers, I've found that there are
> several methods that are not actually called.
>
> InvokerBeanMgr.java
> findUnique
>
> SenderBeanMgr.java
> findUnique
> retrieveFromMessageRefKey
>
> NextMsgBeanMgr
> delete
>
> I'm guessing that the delete method will be used at some point and there
> are places in the code where it is commented out, but will the others?
> Should these methods be removed so people can avoid implementing methods
> that will never be used ?
>
> Also, it would be nice to see some java doc for the methods to describe
> what is expected of the Bean manager implementations.
>
> Thanks
>
> Andrew Gatford
>
> Hursley MP211
> Telephone :
> Internal (7) 245743
> External 01962 815743
> Internet : gatfora@uk.ibm.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: sandesha-dev-help@ws.apache.org
>
>
Re: Sandesha2: Unused methods in the Bean managers
Posted by Chamikara Jayalath <ch...@gmail.com>.
Hi Andrew,
I guess its better to keep the delete and findUnique methods to provide a
consistend API.
But 'retrieveFromMessageRefKey' method is not used any more. I'll deprecate
this.
Chamikara
On 6/29/06, Andrew K Gatford <GA...@uk.ibm.com> wrote:
>
>
> Whilst trying to understand the Bean Managers, I've found that there are
> several methods that are not actually called.
>
> InvokerBeanMgr.java
> findUnique
>
> SenderBeanMgr.java
> findUnique
> retrieveFromMessageRefKey
>
> NextMsgBeanMgr
> delete
>
> I'm guessing that the delete method will be used at some point and there
> are places in the code where it is commented out, but will the others?
> Should these methods be removed so people can avoid implementing methods
> that will never be used ?
>
> Also, it would be nice to see some java doc for the methods to describe
> what is expected of the Bean manager implementations.
>
> Thanks
>
> Andrew Gatford
>
> Hursley MP211
> Telephone :
> Internal (7) 245743
> External 01962 815743
> Internet : gatfora@uk.ibm.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: sandesha-dev-help@ws.apache.org
>
>
Re: Sandesha2: Unused methods in the Bean managers
Posted by Andrew K Gatford <GA...@uk.ibm.com>.
Has anyone any thoughts on this ?
I've also discovered one more -
SequencePropertyBeanMgrImpl.java
updateOrInsert
Should I just go ahead and create a JIRA and remove these methods ?
Andrew Gatford
Hursley MP211
Telephone :
Internal (7) 245743
External 01962 815743
Internet : gatfora@uk.ibm.com
Andrew K
Gatford/UK/IBM@IB
MGB To
sandesha-dev@ws.apache.org
29/06/2006 09:09 cc
Subject
Sandesha2: Unused methods in the
Bean managers
Whilst trying to understand the Bean Managers, I've found that there are
several methods that are not actually called.
InvokerBeanMgr.java
findUnique
SenderBeanMgr.java
findUnique
retrieveFromMessageRefKey
NextMsgBeanMgr
delete
I'm guessing that the delete method will be used at some point and there
are places in the code where it is commented out, but will the others?
Should these methods be removed so people can avoid implementing methods
that will never be used ?
Also, it would be nice to see some java doc for the methods to describe
what is expected of the Bean manager implementations.
Thanks
Andrew Gatford
Hursley MP211
Telephone :
Internal (7) 245743
External 01962 815743
Internet : gatfora@uk.ibm.com
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
Re: Sandesha2: Unused methods in the Bean managers
Posted by Andrew K Gatford <GA...@uk.ibm.com>.
Has anyone any thoughts on this ?
I've also discovered one more -
SequencePropertyBeanMgrImpl.java
updateOrInsert
Should I just go ahead and create a JIRA and remove these methods ?
Andrew Gatford
Hursley MP211
Telephone :
Internal (7) 245743
External 01962 815743
Internet : gatfora@uk.ibm.com
Andrew K
Gatford/UK/IBM@IB
MGB To
sandesha-dev@ws.apache.org
29/06/2006 09:09 cc
Subject
Sandesha2: Unused methods in the
Bean managers
Whilst trying to understand the Bean Managers, I've found that there are
several methods that are not actually called.
InvokerBeanMgr.java
findUnique
SenderBeanMgr.java
findUnique
retrieveFromMessageRefKey
NextMsgBeanMgr
delete
I'm guessing that the delete method will be used at some point and there
are places in the code where it is commented out, but will the others?
Should these methods be removed so people can avoid implementing methods
that will never be used ?
Also, it would be nice to see some java doc for the methods to describe
what is expected of the Bean manager implementations.
Thanks
Andrew Gatford
Hursley MP211
Telephone :
Internal (7) 245743
External 01962 815743
Internet : gatfora@uk.ibm.com
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: sandesha-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: sandesha-dev-help@ws.apache.org