You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:33:41 UTC

[GitHub] [cordova-plugin-geolocation] katzlbt opened a new pull request #225: (ios) Continue watchPosition when the App is suspended and reactivated, fixes #224

katzlbt opened a new pull request #225:
URL: https://github.com/apache/cordova-plugin-geolocation/pull/225


   ### Platforms affected
   iOS
   
   ### Motivation and Context
   Fixes issue https://github.com/apache/cordova-plugin-geolocation/issues/224
   
   ### Description
   ```
   if(error.code == kCLErrorDenied && [self isAuthorized] && [self isLocationServicesEnabled])
      then do not stopUpdatingLocation and thus continue watchPosition after suspending the app and reactivating it
   ```
   ### Testing
   Manual tests on iPhone
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-geolocation] katzlbt commented on pull request #225: (ios) Continue watchPosition when the App is suspended and reactivated, fixes #224

Posted by GitBox <gi...@apache.org>.
katzlbt commented on pull request #225:
URL: https://github.com/apache/cordova-plugin-geolocation/pull/225#issuecomment-830820775


   If #226 is fixed, PERMISSION_DENIED is transmitted to the WebView, although it is not really a user-denial. Should this be done? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org