[GitHub] [spark] huaxingao commented on a change in pull request #33526: [SPARK-34952][SQL][FOLLOW-UP] DSv2 aggregate push down follow-up

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #33526:
URL: https://github.com/apache/spark/pull/33526#discussion_r677544670



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Aggregation.java
##########
@@ -28,17 +28,15 @@
  */
 @Evolving
 public final class Aggregation implements Serializable {
-  private AggregateFunc[] aggregateExpressions;
-  private FieldReference[] groupByColumns;
+  private final AggregateFunc[] aggregateExpressions;
+  private final FieldReference[] groupByColumns;
 
   public Aggregation(AggregateFunc[] aggregateExpressions, FieldReference[] groupByColumns) {
     this.aggregateExpressions = aggregateExpressions;
     this.groupByColumns = groupByColumns;
   }
 
-  public AggregateFunc[] aggregateExpressions() {
-    return aggregateExpressions;
-  }
+  public AggregateFunc[] aggregateExpressions() { return aggregateExpressions; }

Review comment:
       Sorry, the method was automatically collapsed into one single line in my IDE, I only saw one line there. I tried to be careful, but still missed this one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org