[jira] [Commented] (THRIFT-5903) Fixnum is no longer supported since Ruby 3.2

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039674#comment-18039674 ] 

Jens Geyer commented on THRIFT-5903:
------------------------------------

Could you provide a pull request?

> Fixnum is no longer supported since Ruby 3.2
> --------------------------------------------
>
>                 Key: THRIFT-5903
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5903
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Library
>    Affects Versions: 0.22.0
>            Reporter: Xuan Cao
>            Priority: Major
>             Fix For: 0.23.0
>
>
> Fixnum is unified into Integer from Ruby 2.4 ([https://rubyreferences.github.io/rubychanges/2.4.html#fixnum-and-bignum-are-unified-into-integer]) and it was fully depreciated in Ruby 3.2 ([https://www.ruby-lang.org/en/news/2022/12/25/ruby-3-2-0-released/])
> Fixnum is still used in [base_protocol.rb|[https://github.com/apache/thrift/blob/v0.22.0/lib/rb/lib/thrift/protocol/base_protocol.rb#L256]], which will cause issue once reach to the write_type and read_type. I think removing that type check for Fixnum should do the fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)