You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/16 07:59:47 UTC

[GitHub] [dubbo-go] AlexStocks opened a new issue, #1838: Ref: some history smelly codes in dubbogo

AlexStocks opened a new issue, #1838:
URL: https://github.com/apache/dubbo-go/issues/1838

   <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
   
   -->
   
   **What happened**:
   
   some history smelly codes in dubbogo.
   
   **What you expected to happen**:
   
   Please do not write such codes again in dubbogo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks commented on issue #1838: Ref: some history smelly codes in dubbogo

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1838:
URL: https://github.com/apache/dubbo-go/issues/1838#issuecomment-1100600616

   compare with 'nil' which has no type info.
   
   ![image](https://user-images.githubusercontent.com/7959374/163666836-57b3d745-9dc9-47eb-a2ab-2a762c5b7f2a.png)
   from https://github.com/apache/dubbo-go/pull/1833/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks commented on issue #1838: Ref: some history smelly codes in dubbogo

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1838:
URL: https://github.com/apache/dubbo-go/issues/1838#issuecomment-1100600379

   set the Go keyword as var
   
   ![image](https://user-images.githubusercontent.com/7959374/163666954-e146e56b-3e3f-449d-a3cb-3ae9815ba266.png)
   
   from https://github.com/apache/dubbo-go/pull/1833/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks commented on issue #1838: Ref: some history smelly codes in dubbogo

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on issue #1838:
URL: https://github.com/apache/dubbo-go/issues/1838#issuecomment-1100600494

   set the package name as var name
   
   ![image](https://user-images.githubusercontent.com/7959374/163666652-e360833a-72e8-42b1-9100-403b49ce2f71.png)
   
   from https://github.com/apache/dubbo-go/pull/1833/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-go] AlexStocks closed issue #1838: Ref: some history smelly codes in dubbogo

Posted by GitBox <gi...@apache.org>.
AlexStocks closed issue #1838: Ref: some history smelly codes in dubbogo
URL: https://github.com/apache/dubbo-go/issues/1838


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org