You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/05 20:45:01 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2340: Fix cargo publish
alamb opened a new pull request, #2340:
URL: https://github.com/apache/arrow-rs/pull/2340
# Which issue does this PR close?
re https://github.com/apache/arrow-rs/issues/2172
# Rationale for this change
When the release verification script tried to publish the 'arrow' crate, it got the following error:
```
+ pushd arrow
/var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi/apache-arrow-rs-20.0.0/arrow /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi/apache-arrow-rs-20.0.0 /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi
+ cargo publish --dry-run
Updating crates.io index
Packaging arrow v20.0.0 (/private/var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi/apache-arrow-rs-20.0.0/arrow)
Verifying arrow v20.0.0 (/private/var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi/apache-arrow-rs-20.0.0/arrow)
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/private/var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi/apache-arrow-rs-20.0.0/target/package/arrow-20.0.0/Cargo.toml`
Caused by:
can't find `dynamic_types` example at `examples/dynamic_types.rs` or `examples/dynamic_types/main.rs`. Please specify example.path if you want to use a non-default path.
+ cleanup
+ '[' no = yes ']'
+ echo 'Failed to verify release candidate. See /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi for details.'
Failed to verify release candidate. See /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-20.0.0.XXXXX.dVwsseAi for details.
``
I can reproduce it locally too
```
alamb@MacBook-Pro-8 arrow % cargo publish --dry-run
cargo publish --dry-run
Updating crates.io index
Packaging arrow v20.0.0 (/Users/alamb/Software/arrow-rs/arrow)
Verifying arrow v20.0.0 (/Users/alamb/Software/arrow-rs/arrow)
error: failed to verify package tarball
Caused by:
failed to parse manifest at `/Users/alamb/Software/arrow-rs/target/package/arrow-20.0.0/Cargo.toml`
Caused by:
can't find `dynamic_types` example at `examples/dynamic_types.rs` or `examples/dynamic_types/main.rs`. Please specify example.path if you want to use a non-default path.
```
I don't really know what Cargo is complaining about:
```shell
$ ls examples/dynamic_types.rs
examples/dynamic_types.rs
```
🤷
Looks like the change came in from @tustvold 's change on #2299
# What changes are included in this PR?
Add a `path` attribute as suggested by Cargo
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2340: Fix cargo publish ( can't find `dynamic_types` example at `examples/dynamic_types.rs` or `examples/dynamic_types/main.rs`)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2340:
URL: https://github.com/apache/arrow-rs/pull/2340#issuecomment-1206855331
Benchmark runs are scheduled for baseline = 83fab3786fefa0728738a050ac75c6c50da788b3 and contender = 30c94dbf1c422f81f8520b9956e96ab7b53c3f47. 30c94dbf1c422f81f8520b9956e96ab7b53c3f47 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a89c98ba034e44d49e411e9f04f4f732...92e017f0780d4ec8bf69292e5af424b0/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/2a64ad4a2b7c4c44a5bbaf59998c641e...f74f0600e71a456dae461f4f21f19da0/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/abbf3538e5a146fdb21ea152b13cbba1...bad1884ec78e469694cb91c8d8d49ac8/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/85f31c5855ef4d15ad96bcfe2e8d3f9d...e4166e855a464938bfbd05af18cbad43/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #2340: Fix cargo publish ( can't find `dynamic_types` example at `examples/dynamic_types.rs` or `examples/dynamic_types/main.rs`)
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2340:
URL: https://github.com/apache/arrow-rs/pull/2340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2340: Fix cargo publish ( can't find `dynamic_types` example at `examples/dynamic_types.rs` or `examples/dynamic_types/main.rs`)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2340:
URL: https://github.com/apache/arrow-rs/pull/2340#issuecomment-1207193679
I have no idea about this either... Perhaps @carols10cents knows what is going on here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org