[jira] [Commented] (HDFS-7266) HDFS Peercache enabled check should not lock on object

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177384#comment-14177384 ] 

Colin Patrick McCabe commented on HDFS-7266:
--------------------------------------------

+1.  Thanks, Andrew and Gopal.

> HDFS Peercache enabled check should not lock on object
> ------------------------------------------------------
>
>                 Key: HDFS-7266
>                 URL: https://issues.apache.org/jira/browse/HDFS-7266
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.6.0
>            Reporter: Gopal V
>            Assignee: Andrew Wang
>              Labels: multi-threading
>         Attachments: dfs-open-10-threads.png, hdfs-7266.001.patch
>
>
> HDFS fs.Open synchronizes on the Peercache, even when peer cache is disabled.
> {code}
>  public synchronized Peer get(DatanodeID dnId, boolean isDomain) {
>     if (capacity <= 0) { // disabled
>       return null;
>     }
> {code}
> since capacity is a final, this could be moved outside the lock.
> !dfs-open-10-threads.png!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)