[jira] [Reopened] (HDFS-9569) Log the name of the fsimage being loaded for better supportability

["Chris Nauroth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-9569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth reopened HDFS-9569:
---------------------------------

I have reverted this patch from trunk, branch-2, branch-2.8 and branch-2.7.  This patch introduced a test failure in {{TestDFSUpgradeFromImage#testUpgradeFromRel2ReservedImage}}.  The test expects to see an {{IllegalArgumentException}}, and then retry the upgrade with the option to rename reserved paths.  After this patch, the error handling masked the {{IllegalArgumentException}}, so the test no longer worked as expected.

> Log the name of the fsimage being loaded for better supportability
> ------------------------------------------------------------------
>
>                 Key: HDFS-9569
>                 URL: https://issues.apache.org/jira/browse/HDFS-9569
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>              Labels: supportability
>             Fix For: 2.7.3
>
>         Attachments: HDFS-9569.001.patch
>
>
> When NN starts to load fsimage, it does
> {code}
>  void loadFSImageFile(FSNamesystem target, MetaRecoveryContext recovery,
>       FSImageFile imageFile, StartupOption startupOption) throws IOException {
>       LOG.debug("Planning to load image :\n" + imageFile);
>       ......
>     long txId = loader.getLoadedImageTxId();
>     LOG.info("Loaded image for txid " + txId + " from " + curFile);
> {code}
> A debug msg is issued at the beginning with the fsimage file name, then at the end an info msg is issued after loading.
> If the fsimage loading failed due to corrupted fsimage (see HDFS-9406), we don't see the first msg. It'd be helpful to always be able to see from NN logs what fsimage file it's loading.
> Two improvements:
> 1. Change the above debug to info
> 2. If exception happens when loading fsimage, be sure to report the fsimage name being loaded in the error message.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)